Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RegExp in ignoredPaths/ignoredActionPaths #2987

Closed

Conversation

indutny
Copy link
Contributor

@indutny indutny commented Dec 8, 2022

Fix: #2553

@codesandbox
Copy link

codesandbox bot commented Dec 8, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@indutny indutny force-pushed the feature/regexp-in-ignored-paths branch from e4cd61c to 75922fc Compare December 8, 2022 19:30
@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit e4cd61c
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/63923abbab4ac00008e4f4d0
😎 Deploy Preview https://deploy-preview-2987--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 448035c:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 448035c
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/639638a5941f0d0008e3d170
😎 Deploy Preview https://deploy-preview-2987--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@indutny indutny force-pushed the feature/regexp-in-ignored-paths branch from 75922fc to 448035c Compare December 11, 2022 20:08
@indutny
Copy link
Contributor Author

indutny commented Dec 11, 2022

Hah! Sorry, looks like I messed up in the initial version of the Pull Request. Should be fixed now.

@markerikson
Copy link
Collaborator

Hey! I'm trying to update this PR by rebasing it and then adding RegExp support to the immutability middleware as well. I got that working locally, but for some reason I can't force-push to update the branch in your repo. I'm going to close this PR and open a new one. Thanks for getting this working!

@indutny indutny deleted the feature/regexp-in-ignored-paths branch January 28, 2023 18:39
@indutny
Copy link
Contributor Author

indutny commented Jan 28, 2023

No worries! Happy to see it merged! Thanks

@markerikson
Copy link
Collaborator

btw turns out I was being stupid :) I'd copied an HTTP URL to your repo and set that as the remote, when it needed to be an SSH URL. That's why I was getting a 403 error :)

@indutny
Copy link
Contributor Author

indutny commented Jan 28, 2023

Haha, I still don't know how people use HTTP urls for git, so I'd definitely run into the same.

@markerikson
Copy link
Collaborator

In my case, I had copied the branch URL from the top of this page and deleted the /tree/feature/.... part to paste in as the remote URL. Lesson learned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow wildcards in immutable check middleware ignored paths
2 participants