Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

✅ Deploy Preview for redux-starter-kit-docs ready!

Name	Link
🔨 Latest commit	66f7494
🔍 Latest deploy log	https://app.netlify.com/sites/redux-starter-kit-docs/deploys/66e43815dea7520008d60942
😎 Deploy Preview	https://deploy-preview-4549--redux-starter-kit-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 66f7494:

the type changes to miniSerializeError are not safe - the function will only ever return a SerializedError shape, regardless of what your config says.

I have to admit I'm a bit hesitant to add additional runtime code for this, especially with a name like createAsyncThunkCreator, which would probably be picked up by autocomplete a lot.
Also, the whole thing needs a lot of docs and explanation and might confuse people.

Alternative suggestion - we could export something like a CreateAsyncThunkWithoutWithTypes type, which would only be the function signature of the CreateAsyncThunk type without the withTypes callback.

That would make it possible to define something like this in userland:

export const createAppAsyncThunk: CreateAsyncThunkWithoutWithTypes<{
  serializedErrorType: number;
}> = (typePrefix: string, payloadCreator: any, options: any) => {
  return createAsyncThunk(typePrefix, payloadCreator, {
    ...options,
    serializeError: mySerializeError,
  }) as any;
};

What do you think?

I have to admit I'm a bit hesitant to add additional runtime code for this, especially with a name like createAsyncThunkCreator, which would probably be picked up by autocomplete a lot. Also, the whole thing needs a lot of docs and explanation and might confuse people.

Alternative suggestion - we could export something like a CreateAsyncThunkWithoutWithTypes type, which would only be the function signature of the CreateAsyncThunk type without the withTypes callback.

That would make it possible to define something like this in userland:

export const createAppAsyncThunk: CreateAsyncThunkWithoutWithTypes<{
  serializedErrorType: number;
}> = (typePrefix: string, payloadCreator: any, options: any) => {
  return createAsyncThunk(typePrefix, payloadCreator, {
    ...options,
    serializeError: mySerializeError,
  }) as any;
};

What do you think?

Yeah, this looks like a good solution to me.