Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connectAdvanced #1771

Merged
merged 14 commits into from
Sep 4, 2021
Merged

Remove connectAdvanced #1771

merged 14 commits into from
Sep 4, 2021

Conversation

markerikson
Copy link
Contributor

@markerikson markerikson commented Jul 18, 2021

This PR:

  • Consolidates all connect component implementation into a single file and function, and removes the connectAdvanced function and public export

Fixes #1236 , which announced the deprecation of connectAdvanced two years ago.

This is a draft for now, but I intend to merge this after #1737 gets merged into master.

@github-actions
Copy link

github-actions bot commented Jul 18, 2021

Size Change: -1.48 kB (7%) ✅

Total Size: 18.6 kB

Filename Size Change
dist/react-redux.js 14.2 kB -1.24 kB (8%)
dist/react-redux.min.js 4.46 kB -244 B (5%)

compressed-size-action

@netlify
Copy link

netlify bot commented Jul 18, 2021

✔️ Deploy Preview for react-redux-docs ready!

🔨 Explore the source changes: c7b1bc1

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/6132d405ddec14000832de9b

😎 Browse the preview: https://deploy-preview-1771--react-redux-docs.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c7b1bc1:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

Base automatically changed from typescript-port to master July 28, 2021 22:46
@markerikson markerikson marked this pull request as ready for review September 4, 2021 01:45
@markerikson markerikson force-pushed the feature/remove-connectadvanced branch from 9614da8 to d98c91c Compare September 4, 2021 01:52
@markerikson markerikson force-pushed the feature/remove-connectadvanced branch from d98c91c to c7b1bc1 Compare September 4, 2021 02:03
@markerikson
Copy link
Contributor Author

Goodbye!

@markerikson markerikson merged commit f278933 into master Sep 4, 2021
@markerikson markerikson deleted the feature/remove-connectadvanced branch September 4, 2021 02:07
@sktguha
Copy link

sktguha commented Sep 4, 2021

Good riddance 😂🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecating connectAdvanced
2 participants