Reuse latest selected state on selector re-run (#1654) #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit b53d184 |
jgibson02
reviewed
Dec 3, 2020
| count: count + 1, | ||
| })) | ||
|
|
||
| const alwaysEqual = () => true |
There was a problem hiding this comment.
Does this also maintain the latest state if the equalityFn is defined within the component or inline?
There was a problem hiding this comment.
Yes—it only cares what the equalityFn returns, not what its identity is. However, having a non-pure equalityFn (i.e., one that closes over variables from its surrounding components) could have very surprising results.
nightpool
reviewed
Dec 3, 2020
Co-authored-by: nightpool <[email protected]>
|
Seems reasonable, I think. |
|
I'm encountering the same issue, and this would be a nice fix. Is there something I can do to help with merging this PR? |
|
Yeah, let's do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it is a simple fix or a potential breaking change, but reuse latest selected state is quite important in preventing components from re-render frequently