Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add / change docs about v6 #1148

Merged
merged 7 commits into from
Dec 28, 2018
Merged

Add / change docs about v6 #1148

merged 7 commits into from
Dec 28, 2018

Conversation

wgao19
Copy link
Contributor

@wgao19 wgao19 commented Dec 27, 2018

What does this PR do?

Regarding #1001, addressing #1104, #1123, #1132:

Add docs regarding v6 changes.

Summary of the Changes

  • Quick Start: Add a section regarding passing context to <Provider /> and connected components
  • Provider API: Remove the note about direct passing store as props to connected component
  • Provider API: Add context props
  • New page: Add a doc page about accessing the store with v6

Are there points in the code the reviewer needs to double check

Please feel free to make changes if my understanding is off from the intended use case.

@netlify
Copy link

netlify bot commented Dec 27, 2018

Deploy preview for react-redux-docs ready!

Built with commit 71afd42

https://deploy-preview-1148--react-redux-docs.netlify.com

@markerikson markerikson merged commit 75b90f9 into reduxjs:master Dec 28, 2018
@markerikson
Copy link
Contributor

Thanks!

Did some rework on the main page content. Removed the additions to "Quick Start", because I don't think that's something that needs to be emphasized. Also used this branch to copy over all the CSS updates from the main site.

albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
* Add v6 related info to Quick Start

* Remove doc regarding directly passing store

* Add doc passing `context` to `<Provider />`

* Add docs around accessing store with v6

* Rework "Accessing Store" content

Reordered sections
Added explanation of internals and warning note

* Remove context content from "Quick Start"

* Copy CSS changes from main Redux site
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants