Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cases coverge coverage.Icov is empty #828

Closed
ahmdsolmn opened this issue Nov 15, 2017 · 5 comments · Fixed by #850
Closed

test cases coverge coverage.Icov is empty #828

ahmdsolmn opened this issue Nov 15, 2017 · 5 comments · Fixed by #850

Comments

@ahmdsolmn
Copy link

I tried cloning and running test coverage but coverge.Icov is empty.

Steps to reproduce:

  1. clone and npm install

  2. npm run test:cov

    All test cases succeed but coverage looks like this in the terminal

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|

and the coverage.Icov file is empty

@timdorr
Copy link
Member

timdorr commented Nov 15, 2017

I haven't touched coverage in over a year. We should probably get it working again.

@ahmdsolmn
Copy link
Author

ahmdsolmn commented Nov 16, 2017

if your run npm run test:cov returns unknown
but if you edit /src/utils/shallowEqual.js line 12 and add a semicolon at the end then rerun npm run test:cov shallowEqual.js shows in the coverage.


also if you edit src/utils/wrapActionCreators.js line 1 and add a semicolon at the end and then rerun npm run test:cov wrapActionCreators.js shows in the coverage.


Not sure what it means actually but maybe it will help you discover something

@IlyaRucavitcyn
Copy link

If nobody is working on that issue could I have a try during next few days? This issue seems a good one to start with:)

@timdorr
Copy link
Member

timdorr commented Dec 11, 2017

Absolutely. It's a race to the PR! 😄

@IlyaRucavitcyn
Copy link

This days I've been working on the issue and for now I am stuck and perhaps need some help or advise.
For now I have managed to change config of the nyc (istanbul cli) as shown on the picture below:
screen shot 2017-12-12 at 11 21 18 am
and all the src folder files appear to be in the report but with some kind of strange coverage results
screen shot 2017-12-12 at 11 21 36 am

Current investigaton and nyc/babel/istanbul issues checking didn't point at the idea of what could have happened here.
Any ideas from anyone where to point the attention to?
Original changes can be found in the fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants