Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Recording to MP4 #467

Open
XPZ2k15 opened this issue Jul 29, 2024 · 4 comments
Open

[Feature] Recording to MP4 #467

XPZ2k15 opened this issue Jul 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@XPZ2k15
Copy link

XPZ2k15 commented Jul 29, 2024

Device

Desktop

Operating System

Windows

Browser

Chrome/Edge/Chromium

Suggestion

I have gone ahead and added a record feature with 2 hotkeys

hotkey . (This will record for 1 minute)

hotkey / (This will start and stop recording)

I've also added 1 button next to screenshot to manually click it

Can I merge this feature? It took some testing, but I got it to work!

image

image

image

@XPZ2k15 XPZ2k15 added the enhancement New feature or request label Jul 29, 2024
@redphx
Copy link
Owner

redphx commented Jul 29, 2024

Thank you. Please create a MR and I'll check it later.

@Danfun64
Copy link

Why does it have to be limited to 1 minute?

@redphx
Copy link
Owner

redphx commented Sep 7, 2024

I still have mixed thoughts about this feature

  • Limiting to 1 minute record is not useful
  • Having longer records will likely run into memory problem. If it crashes users will complain about it.
  • Making this feature work in Android app also a problem (same memory problem)

That's why I've yet to decide whether to implement this feature or not

@XPZ2k15
Copy link
Author

XPZ2k15 commented Sep 9, 2024

@redphx ,

To be honest it depends on what games you are playing.example for valorant a given round is about 1 minute and 45 seconds. When a user makes a play or highlight, that play for example would probably be 1 minute long due to the structure of the game. Let's say you play madden and you have a nice kick off return, that clip would be about 25 seconds max.

I would say an adjustable time would be beneficial. I think 1 minute is plenty for most games.

As far a memory issue on android, I can test this on android. It really depends on the person's phone. Example, I have a s21 ultra. Is there a work around to this? Possibly, I can think of a few ways to get around the memory issue.

If you want me to try and optimize it for Android, let me know. I'll throw a few hours at it and test.

Edit: also, you can implement a max time to avoid crashing users. You can keep it a variable max time by pulling the android memory and seeing what is utilizable. Thus, if a phone has less memory then the max limit should be lowered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants