-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Recording to MP4 #467
Comments
Thank you. Please create a MR and I'll check it later. |
Why does it have to be limited to 1 minute? |
I still have mixed thoughts about this feature
That's why I've yet to decide whether to implement this feature or not |
@redphx , To be honest it depends on what games you are playing.example for valorant a given round is about 1 minute and 45 seconds. When a user makes a play or highlight, that play for example would probably be 1 minute long due to the structure of the game. Let's say you play madden and you have a nice kick off return, that clip would be about 25 seconds max. I would say an adjustable time would be beneficial. I think 1 minute is plenty for most games. As far a memory issue on android, I can test this on android. It really depends on the person's phone. Example, I have a s21 ultra. Is there a work around to this? Possibly, I can think of a few ways to get around the memory issue. If you want me to try and optimize it for Android, let me know. I'll throw a few hours at it and test. Edit: also, you can implement a max time to avoid crashing users. You can keep it a variable max time by pulling the android memory and seeing what is utilizable. Thus, if a phone has less memory then the max limit should be lowered. |
Device
Desktop
Operating System
Windows
Browser
Chrome/Edge/Chromium
Suggestion
I have gone ahead and added a record feature with 2 hotkeys
hotkey . (This will record for 1 minute)
hotkey / (This will start and stop recording)
I've also added 1 button next to screenshot to manually click it
Can I merge this feature? It took some testing, but I got it to work!
The text was updated successfully, but these errors were encountered: