[CORE-13087] dl/coordinator: don't purge data when dropping Glue table #27367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need another kludge for Glue (to not purge tables when dropping, which isn't currently supported by Glue), so this pulls out the Glue-detecting logic for reuse in a subsequent commit.
Glue doesn's support the purgeRequested option when dropping tables, and will reject our requests indefinitely when a tombstone exists. This ends up blocking topic tombstone removal, and therefore blocks subsequent Iceberg topics of the same name from translating any data. This commit plumbs a bool to the drop_table() command that is false for Glue. I considered doing this in the catalog layer, but opted to be more explicit (it's hopeflly less surprising for readers that way). Manually tested this against Glue: 1. create an Iceberg topic 2. produce to the Iceberg topic and wait for Iceberg commits 3. drop the Iceberg topic 4. witness the drop table op eventually succeeding in Glue 5. manually delete the data in Iceberg 6. recreate the topic and produce without issues ...as well as another sequence where I didn't do step 4 and instead immediately went on to delete data and recreate the topic. In both cases, the Redpanda coordinator was not blocked and could produce to the new topic without issues.
andrwng
changed the title
nvartolomei
approved these changes
Aug 26, 2025
Collaborator
|
/backport v25.2.x |
Collaborator
|
/backport v25.1.x |
Collaborator
|
Failed to create a backport PR to v25.1.x branch. I tried: |
This was referenced Aug 26, 2025
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glue doesn's support the purgeRequested option when dropping tables, and
will reject our requests indefinitely when a tombstone exists. This ends
up blocking topic tombstone removal, and therefore blocks subsequent
Iceberg topics of the same name from translating any data.
This commit plumbs a bool to the drop_table() command that is false for
Glue.
I considered doing this in the catalog layer, but opted to be more
explicit (it's hopeflly less surprising for readers that way).
Manually tested this against Glue:
...as well as another sequence where I didn't do step 4 and instead
immediately went on to delete data and recreate the topic. In both
cases, the Redpanda coordinator was not blocked and could produce to the
new topic without issues.
Kludge for https://redpandadata.atlassian.net/browse/CORE-13087
Backports Required
Release Notes
Bug Fixes
purgeRequested=trueoption when dropping tables. This would previously result in commits to Iceberg being blocked when an Iceberg topic was deleted and recreated.