Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.3.x] CORE-8616 redpanda: configurable sleep on crash loop #24825

Open
wants to merge 2 commits into
base: v24.3.x
Choose a base branch
from
Open

[v24.3.x] CORE-8616 redpanda: configurable sleep on crash loop #24825

wants to merge 2 commits into from
+61 −11

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #24787

@pgellert @vbotbuildovich
redpanda: configurable sleep on crash loop
ca108b2 
This introduces the node config `crash_loop_sleep`.

When redpanda detects that it reached the crash loop limit, instead of
terminating immediately, it should sleep for `crash_loop_sleep` seconds
before terminating.

This is useful especially in a Kubernetes environment where setting this
value allows customers to have ssh access into a crashlooping pod for a
short window of time.

(cherry picked from commit 31e0349)
@pgellert @vbotbuildovich
dt: test crash_loop_sleep config
b8558ed 
It also enabled debug-level logging for the main logger (which the crash
loop limiter uses) for easier debugging.

(cherry picked from commit 3192708)
@vbotbuildovich vbotbuildovich requested a review from a team as a code owner January 15, 2025 17:30
@vbotbuildovich vbotbuildovich added this to the v24.3.x-next milestone Jan 15, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 15, 2025
@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#60796
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60796#01946b05-2933-4079-b8ac-d49904b03074 FAIL 0/2

@pgellert pgellert self-assigned this Jan 16, 2025
@pgellert
Copy link
Contributor

/ci-repeat 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgellert pgellert Awaiting requested review from pgellert

At least 1 approving review is required to merge this pull request.

Assignees

@pgellert pgellert

Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.3.x-next
Development

Successfully merging this pull request may close these issues.
2 participants
@vbotbuildovich @pgellert