add tests

Author: paulohtb6

__tests__/tools/topic_property_extractor.test.js

@@ -12,12 +12,22 @@ describe('topic_property_extractor.py', () => {
     // Create a minimal mock Redpanda source tree
     if (!fs.existsSync(mockSourcePath)) {
       fs.mkdirSync(mockSourcePath, { recursive: true });
-      // Create a mock header file with a topic property
+      // Create a mock header file with topic properties and no-op allowlist
       const headerDir = path.join(mockSourcePath, 'src/v/kafka/server/handlers/topics');
       fs.mkdirSync(headerDir, { recursive: true });
       fs.writeFileSync(
         path.join(headerDir, 'types.h'),
-        'inline constexpr std::string_view topic_property_retention_ms = "retention.ms";\n'
+        `inline constexpr std::string_view topic_property_retention_ms = "retention.ms";
+inline constexpr std::string_view topic_property_segment_bytes = "segment.bytes";
+inline constexpr std::string_view topic_property_flush_messages = "flush.messages";
+
+// Mock allowlist for no-op properties
+inline constexpr std::array<std::string_view, 3> allowlist_topic_noop_confs = {
+  "flush.messages",
+  "segment.index.bytes",
+  "preallocate",
+};
+`
       );
       // Add a mock .cc file (should be ignored for property extraction)
       fs.writeFileSync(
@@ -29,7 +39,7 @@ describe('topic_property_extractor.py', () => {
       fs.mkdirSync(configDir, { recursive: true });
       fs.writeFileSync(
         path.join(configDir, 'mock_config.cc'),
-        'config.get("log_retention_ms");\n'
+        'config.get("log_retention_ms");\nconfig.get("log_segment_size");\n'
       );
     }
   });
@@ -49,10 +59,39 @@ describe('topic_property_extractor.py', () => {
     expect(result.topic_properties['retention.ms'].property_name).toBe('retention.ms');
   });
 
-  it('generates AsciiDoc output', () => {
+  it('detects no-op properties correctly', () => {
+    execSync(`python3 ${scriptPath} --source-path ${mockSourcePath} --output-json ${outputJson}`);
+    const result = JSON.parse(fs.readFileSync(outputJson, 'utf8'));
+    
+    // Check that noop_properties array is present
+    expect(result.noop_properties).toBeDefined();
+    expect(Array.isArray(result.noop_properties)).toBe(true);
+    expect(result.noop_properties).toContain('flush.messages');
+    expect(result.noop_properties).toContain('segment.index.bytes');
+    expect(result.noop_properties).toContain('preallocate');
+    
+    // Check that flush.messages is marked as no-op
+    if (result.topic_properties['flush.messages']) {
+      expect(result.topic_properties['flush.messages'].is_noop).toBe(true);
+    }
+    
+    // Check that regular properties are not marked as no-op
+    expect(result.topic_properties['retention.ms'].is_noop).toBe(false);
+    expect(result.topic_properties['segment.bytes'].is_noop).toBe(false);
+  });
+
+  it('excludes no-op properties from AsciiDoc generation', () => {
     execSync(`python3 ${scriptPath} --source-path ${mockSourcePath} --output-adoc ${outputAdoc}`);
     const adoc = fs.readFileSync(outputAdoc, 'utf8');
+    
+    // Should contain regular properties
     expect(adoc).toContain('= Topic Configuration Properties');
     expect(adoc).toContain('retention.ms');
+    expect(adoc).toContain('segment.bytes');
+    
+    // Should NOT contain no-op properties in documentation
+    expect(adoc).not.toContain('flush.messages');
+    expect(adoc).not.toContain('segment.index.bytes');
+    expect(adoc).not.toContain('preallocate');
   });
 });