Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging- Feature request #278

Closed
dojowahi opened this issue Oct 31, 2023 · 5 comments
Closed

Add logging- Feature request #278

dojowahi opened this issue Oct 31, 2023 · 5 comments

Comments

@dojowahi
Copy link

If we add how logging can be incorporated, when API calls are made, using middleware it will cover all facets.
@rednafi
Copy link
Owner

rednafi commented Oct 31, 2023

Indeed. I’m curious to see what you have in mind. Would you like to work on that? It’ll need tests too.

@dojowahi
Copy link
Author

I was thinking of having a logging.conf, and then building off it in different modules. A separate folder for middleware, which automatically gets called before and after and after API call is made. It has some sort of unique ID for each request so you can trace which logs come from the same requests, and also time taken by API

@rednafi
Copy link
Owner

rednafi commented Oct 31, 2023

Not a bad idea. I have to see the first pass to make a comment on that.

@priamai
Copy link

priamai commented Oct 22, 2024

+1 on this is amazing!

@rednafi
Copy link
Owner

rednafi commented Oct 25, 2024

A basic logged added.

#316

@rednafi rednafi closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rednafi @dojowahi @priamai