Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test go1.22 on Github Action Matrix #554

Closed
rueian opened this issue Jun 2, 2024 · 9 comments
Closed

Test go1.22 on Github Action Matrix #554

rueian opened this issue Jun 2, 2024 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rueian
Copy link
Collaborator

rueian commented Jun 2, 2024

The PR #553 brings go1.22 dependencies to rueidis, so we need to test it with go1.22 as well and Github Action Matrix can help us.

We should add a new go-version variable with values including 1.21 and 1.22 to the matrix:

strategy:
fail-fast: false
matrix:
module: ${{fromJson(needs.prepare-matrix.outputs.matrix)}}

@rueian rueian added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 2, 2024
This was referenced Jun 2, 2024
@mahiro72
Copy link

mahiro72 commented Jun 4, 2024

Hey @rueian , can I work on this one?

@rueian
Copy link
Collaborator Author

rueian commented Jun 4, 2024

Hi @mahiro72,

We may wait for JayChavan-23 a little bit. He said he would take this: #552 (comment)

@LWF15
Copy link
Contributor

LWF15 commented Jun 6, 2024

Hey @rueian , can I work on this one?

can i do this with you?

@JayChavan-23
Copy link
Contributor

Hey @mahiro72,

I am currently working on this. If I encounter any issues, can we collaborate on it together? Alright?

@mahiro72
Copy link

mahiro72 commented Jun 7, 2024

@JayChavan-23 Yes, sure!

@JayChavan-23
Copy link
Contributor

@rueian @mahiro72 @SoulPancake
I’m having some trouble getting started since I’m a beginner. Can you help me by explaining where I should start and the flow I should follow? I want to try working on it by myself, but if I can't make progress in the next couple of days, I’m open to collaboration. A little heads-up would be appreciated.

Thank you!

@rueian
Copy link
Collaborator Author

rueian commented Jun 9, 2024

@rueian @mahiro72 @SoulPancake I’m having some trouble getting started since I’m a beginner. Can you help me by explaining where I should start and the flow I should follow? I want to try working on it by myself, but if I can't make progress in the next couple of days, I’m open to collaboration. A little heads-up would be appreciated.

Thank you!

Hi @JayChavan-23, I think the following changes are required to be made.

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1234567..89abcde 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -14,6 +14,7 @@ jobs:
       matrix:
         module: ${{fromJson(needs.prepare-matrix.outputs.matrix)}}
+        go-version: ['1.21.0', '1.22.0']
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -22,7 +23,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21.0'
+          go-version: ${{ matrix.go-version }}

       - name: Test Module
         run: |

These changes are generated by ChatGPT and may not be accurate.

@JayChavan-23
Copy link
Contributor

Thanks for the heads-up. I'm working on it

@rueian
Copy link
Collaborator Author

rueian commented Jun 12, 2024

Resolved by #563

@rueian rueian closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants