-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test go1.22 on Github Action Matrix #554
Comments
Hey @rueian , can I work on this one? |
Hi @mahiro72, We may wait for JayChavan-23 a little bit. He said he would take this: #552 (comment) |
can i do this with you? |
Hey @mahiro72, I am currently working on this. If I encounter any issues, can we collaborate on it together? Alright? |
@JayChavan-23 Yes, sure! |
@rueian @mahiro72 @SoulPancake Thank you! |
Hi @JayChavan-23, I think the following changes are required to be made. diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1234567..89abcde 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -14,6 +14,7 @@ jobs:
matrix:
module: ${{fromJson(needs.prepare-matrix.outputs.matrix)}}
+ go-version: ['1.21.0', '1.22.0']
steps:
- name: Checkout code
uses: actions/checkout@v4
@@ -22,7 +23,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
- go-version: '1.21.0'
+ go-version: ${{ matrix.go-version }}
- name: Test Module
run: | These changes are generated by ChatGPT and may not be accurate. |
Thanks for the heads-up. I'm working on it |
Resolved by #563 |
The PR #553 brings go1.22 dependencies to rueidis, so we need to test it with go1.22 as well and Github Action Matrix can help us.
We should add a new
go-version
variable with values including 1.21 and 1.22 to the matrix:rueidis/.github/workflows/build.yml
Lines 19 to 22 in 37fc75f
The text was updated successfully, but these errors were encountered: