Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have any plan of supports RedisSearch? #1154

Closed
roharon opened this issue Sep 11, 2022 · 2 comments
Closed

Have any plan of supports RedisSearch? #1154

roharon opened this issue Sep 11, 2022 · 2 comments

Comments

@roharon
Copy link
Contributor

roharon commented Sep 11, 2022

I guess redis-rb is not supports RedisSearch in Redis Stack yet, although redis-py supports it.

Is there any consideration of supports RedisSearch's command?
Or just not supports because it's just included in RedisStack, not Redis?

If there is no reason and will supports RedisSearch's commands in the future, can I add commands of RedisSearch?

@byroot
Copy link
Collaborator

byroot commented Sep 12, 2022

I have no plan to support extensions, we're already behind on core commands, and as lined-out in #1070, having to keep up with commands signature changes is quite painful.

What I'd be open to would be to make it easy for gems to add extensions commands. Right now it's fairly easy, just not documented.

But basically:

module MyRedisExtension
  def some_command(some_args)
    send_command(["COMMAND", some_args]) do |reply|
      reply # do any transformation needed here
    end
  end
end

Redis.include(MyRedisExtension)

@roharon
Copy link
Contributor Author

roharon commented Sep 14, 2022

Got it!
I will use that.

@roharon roharon closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants