Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic_startup_nodes parameter to async RedisCluster #3447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kakadus
Copy link

@Kakadus Kakadus commented Nov 28, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

The async version of the RedisCluster lacked the dynamic_startup_nodes parameter. This PR adds the parameter to be activated when dynamic DNS endpoints for startup nodes are in use.

Enabling dynamic_startup_nodes fixes #2472, which describes the problem in detail.

#3111 also addresses said issue, but their logic is different to the sync version, while this approach moves the behaviour of the async version closer to the sync version.

@Kakadus Kakadus force-pushed the add-dynamic-startup-nodes-flag-to-async-redis-cluster branch from c9ca010 to cce34d7 Compare November 28, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async redis cluster should use initial startup nodes during reinitialization in case of failover
1 participant