You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
I have a ConnectionPool with connection_class=UnixDomainSocketConnection.
In order to verify the socket is unreachable, we send a ping command and expect to get a ConnectionError, but starting v4.1.0 we get an AttributeError instead.
Then I terminate the process that is responsible for the above socket, and do: rc.ping() in order to know the socket is unreachable, from which I expect to get a ConnectionError (this is what we got from the ping in earlier versions).
But instead, in v4.1.0 (and v4.1.1) I get: AttributeError: 'UnixDomainSocketConnection' object has no attribute 'host'.
I investigated a little and seems like changing the socket.error to OSError in connections.py caused ConnectionResetError to get caught by an earlier except clause, where self.host is printed (and of course UnixDomainSocketConnection doesn't have one).
Thanks!
The text was updated successfully, but these errors were encountered:
Version: v4.1.0
Platform: python 3.9
Description:
I have a
ConnectionPool
withconnection_class=UnixDomainSocketConnection
.In order to verify the socket is unreachable, we send a
ping
command and expect to get aConnectionError
, but starting v4.1.0 we get anAttributeError
instead.Then I terminate the process that is responsible for the above socket, and do:
rc.ping()
in order to know the socket is unreachable, from which I expect to get aConnectionError
(this is what we got from theping
in earlier versions).But instead, in v4.1.0 (and v4.1.1) I get:
AttributeError: 'UnixDomainSocketConnection' object has no attribute 'host'
.I investigated a little and seems like changing the
socket.error
toOSError
inconnections.py
causedConnectionResetError
to get caught by an earlierexcept
clause, whereself.host
is printed (and of courseUnixDomainSocketConnection
doesn't have one).Thanks!
The text was updated successfully, but these errors were encountered: