Aligned lhash* test-files' names with name inside file #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hi @filipecosta90 , please take a look |
Contributor
|
@markovamaria the name should be hash and not lhash |
Collaborator
Author
It is fine, I'll rework. What is correct combination "hincrby" or "hincbry" ? |
markovamaria
force-pushed
the
lhash_tests_names
branch
from
7880cd8 to
7a44035
Compare
markovamaria
force-pushed
the
lhash_tests_names
branch
from
7a44035 to
edc1855
Compare
Collaborator
Author
|
@filipecosta90 , I aligned names in description with file name. As result took "hincrby" as correct one. Please let me know if this should be fixed. |
Collaborator
Author
|
@filipecosta90 , could you please take a look? |
filipecosta90
approved these changes
Apr 20, 2023
Contributor
Thank you Maria. Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There difference in file test with test description and "name" in test's description itself.
Suggest to align tests' names by renaming of files:
$ less memtier_benchmark-1Mkeys-hash-hincrby.yml | grep name
name: memtier_benchmark-1Mkeys-lhash-hincbry
$ less memtier_benchmark-1Mkeys-hash-hexists.yml | grep name
name: memtier_benchmark-1Mkeys-lhash-hexists
Suggested solution - align name in description with file name.