Skip to content

Commit b2e2cc5

Browse files
authored
Remove WATCH from Transaction (#2033)
* Remove WATCH from Transaction Redis doesn't support WATCH within MULTI * Add UNWATCH in pipeline interfaces * Remove watch and unwatch from Transaction
1 parent ec49cd7 commit b2e2cc5

File tree

5 files changed

+10
-42
lines changed

5 files changed

+10
-42
lines changed

src/main/java/redis/clients/jedis/MultiKeyPipelineBase.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -411,18 +411,6 @@ public Response<Long> sunionstore(byte[] dstkey, byte[]... keys) {
411411
return getResponse(BuilderFactory.LONG);
412412
}
413413

414-
@Override
415-
public Response<String> watch(String... keys) {
416-
client.watch(keys);
417-
return getResponse(BuilderFactory.STRING);
418-
}
419-
420-
@Override
421-
public Response<String> watch(byte[]... keys) {
422-
client.watch(keys);
423-
return getResponse(BuilderFactory.STRING);
424-
}
425-
426414
@Override
427415
public Response<String> unwatch() {
428416
client.unwatch();

src/main/java/redis/clients/jedis/Pipeline.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,4 +156,14 @@ public void close() {
156156
clear();
157157
}
158158

159+
public Response<String> watch(String... keys) {
160+
client.watch(keys);
161+
return getResponse(BuilderFactory.STRING);
162+
}
163+
164+
public Response<String> watch(byte[]... keys) {
165+
client.watch(keys);
166+
return getResponse(BuilderFactory.STRING);
167+
}
168+
159169
}

src/main/java/redis/clients/jedis/Transaction.java

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -91,30 +91,4 @@ public void setClient(Client client) {
9191
public void close() {
9292
clear();
9393
}
94-
95-
private static final String WATCH_INSIDE_MULTI_MESSAGE = "WATCH inside MULTI is not allowed";
96-
97-
/**
98-
* @param keys
99-
* @return
100-
* @throws UnsupportedOperationException
101-
* @deprecated {@value #WATCH_INSIDE_MULTI_MESSAGE}
102-
*/
103-
@Override
104-
@Deprecated
105-
public Response<String> watch(String... keys) throws UnsupportedOperationException {
106-
throw new UnsupportedOperationException(WATCH_INSIDE_MULTI_MESSAGE);
107-
}
108-
109-
/**
110-
* @param keys
111-
* @return
112-
* @throws UnsupportedOperationException
113-
* @deprecated {@value #WATCH_INSIDE_MULTI_MESSAGE}
114-
*/
115-
@Override
116-
@Deprecated
117-
public Response<String> watch(byte[]... keys) throws UnsupportedOperationException {
118-
throw new UnsupportedOperationException(WATCH_INSIDE_MULTI_MESSAGE);
119-
}
12094
}

src/main/java/redis/clients/jedis/commands/MultiKeyBinaryRedisPipeline.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ public interface MultiKeyBinaryRedisPipeline {
7575

7676
Response<Long> sunionstore(byte[] dstkey, byte[]... keys);
7777

78-
Response<String> watch(byte[]... keys);
79-
8078
Response<String> unwatch();
8179

8280
Response<Set<byte[]>> zdiff(byte[]... keys);

src/main/java/redis/clients/jedis/commands/MultiKeyCommandsPipeline.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@ Response<String> blmove(String srcKey, String dstKey, ListDirection from, ListDi
8383

8484
Response<Long> sunionstore(String dstkey, String... keys);
8585

86-
Response<String> watch(String... keys);
87-
8886
Response<String> unwatch();
8987

9088
Response<Set<String>> zdiff(String... keys);

0 commit comments

Comments
 (0)