Skip to content

E2e/ri 7131 е2е tests are failing for both app image and docker #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2025
Merged

E2e/ri 7131 е2е tests are failing for both app image and docker #4610

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ef8503
RI-7131 - е2е tests are failing for both app image and docker - fixed…
Jun 5, 2025
6b589b0
RI-7131 - е2е tests are failing for both app image and docker - fixed…
Jun 5, 2025
31f65ed
RI-7131 - е2е tests are failing for both app image and docker - testi…
Jun 6, 2025
ae64d56
RI-7131 - е2е tests are failing for both app image and docker - skipp…
Jun 9, 2025
2449a67
E2e/ri 7131 docker handling (#4638)
Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/e2e/pageObjects/browser-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,8 +948,14 @@ export class BrowserPage extends InstancePage {
*/
async selectIndexByName(index: string): Promise<void> {
const option = Selector(`[data-test-subj="mode-option-type-${index}"]`);
const placeholder = Selector('[data-testid="select-index-placeholder"]');
const dropdown = Selector('[data-testid="select-search-mode"]');

// Click placeholder if it exists, otherwise click dropdown
const triggerElement = await placeholder.exists ? placeholder : dropdown;

await t
.click(this.selectIndexDdn)
.click(triggerElement)
.click(option);
}

Expand Down
8 changes: 5 additions & 3 deletions tests/e2e/pageObjects/dialogs/add-redis-database-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export class AddRedisDatabaseDialog {
// BUTTONS
addDatabaseButton = Selector('[data-testid^=add-redis-database]');
addRedisDatabaseButton = Selector('[data-testid=btn-submit]');
addRedisDatabaseButtonHover = Selector('[data-testid=btn-submit]').parent();
customSettingsButton = Selector('[data-testid=btn-connection-settings]');
addAutoDiscoverDatabase = Selector('[data-testid=add-database_tab_software]');
addCloudDatabaseButton = Selector('[data-testid=create-free-db-btn]');
Expand All @@ -27,6 +28,7 @@ export class AddRedisDatabaseDialog {
cloneDatabaseButton = Selector('[data-testid=clone-db-btn]');
cancelButton = Selector('[data-testid=btn-cancel]');
testConnectionBtn = Selector('[data-testid=btn-test-connection]');
testConnectionBtnHover = Selector('[data-testid=btn-test-connection]').parent();
backButton = Selector('[data-testid=back-btn]');
generalTab = Selector('[data-testid=manual-form-tab-general]');
securityTab = Selector('[data-testid=manual-form-tab-security]');
Expand Down Expand Up @@ -61,14 +63,14 @@ export class AddRedisDatabaseDialog {
selectCompressor = Selector('[data-testid=select-compressor]', { timeout: 1000 });
certificateDropdownList = Selector('div.euiSuperSelect__listbox div');
// CHECKBOXES
useSSHCheckbox = Selector('[data-testid=use-ssh]~div', { timeout: 500 });
useSSHCheckbox = Selector('[data-testid=use-ssh] ~ label', { timeout: 500 });
dataCompressorCheckbox = Selector('[data-testid=showCompressor] ~ label');
requiresTlsClientCheckbox = Selector('[data-testid=tls-required-checkbox] ~ label');
useCloudAccount = Selector('#cloud-account').parent();
useCloudKeys = Selector('#cloud-api-keys').parent();
// RADIO BUTTONS
sshPasswordRadioBtn = Selector('#password~div', { timeout: 500 });
sshPrivateKeyRadioBtn = Selector('#privateKey~div', { timeout: 500 });
sshPasswordRadioBtn = Selector('[for="password"]', { timeout: 500 });
sshPrivateKeyRadioBtn = Selector('[for="privateKey"]', { timeout: 500 });
cloudOptionsRadioBtn = Selector('[data-testid=cloud-options]');
// LABELS
dataCompressorLabel = Selector('[data-testid=showCompressor] ~ label', { timeout: 1000 });
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/tests/electron/critical-path/database/add-ssh-db.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ test
.click(myRedisDatabasePage.AddRedisDatabaseDialog.securityTab)
.click(myRedisDatabasePage.AddRedisDatabaseDialog.useSSHCheckbox)
.click(myRedisDatabasePage.AddRedisDatabaseDialog.sshPrivateKeyRadioBtn)
.hover(myRedisDatabasePage.AddRedisDatabaseDialog.addRedisDatabaseButton);
.hover(myRedisDatabasePage.AddRedisDatabaseDialog.addRedisDatabaseButtonHover);
for (const text of tooltipText) {
await browserActions.verifyTooltipContainsText(text, true);
}
// Verify that user can see the Test Connection button enabled/disabled with the same rules as the button to add/apply the changes
await t.hover(myRedisDatabasePage.AddRedisDatabaseDialog.testConnectionBtn);
await t.hover(myRedisDatabasePage.AddRedisDatabaseDialog.testConnectionBtnHover);
for (const text of tooltipText) {
await browserActions.verifyTooltipContainsText(text, true);
}
Expand Down
Loading