Merge pull request #4199 from RedisInsight/be/bugfix/fix-tests

fix tests

Author: ArtemHoruzhenko

redisinsight/api/src/__mocks__/cloud-common.ts

@@ -1,9 +1,8 @@
 import { HttpStatus } from '@nestjs/common';
-import ERROR_MESSAGES from 'src/constants/error-messages';
 import { CustomErrorCodes } from 'src/constants';
 
 export const mockCapiUnauthorizedError = {
-  message: 'Request failed with status code 401',
+  message: 'Custom unauthorized message',
   response: {
     status: 401,
   },
@@ -12,14 +11,14 @@ export const mockCapiUnauthorizedError = {
 export const mockSmApiUnauthorizedError = mockCapiUnauthorizedError;
 
 export const mockSmApiInternalServerError = {
-  message: 'Something wrong',
+  message: 'Custom server error message',
   response: {
     status: 500,
   },
 };
 
 export const mockSmApiBadRequestError = {
-  message: 'Bad Request',
+  message: 'Custom bad request message',
   response: {
     status: 400,
   },
@@ -34,13 +33,13 @@ export const mockUtm = {
 export const mockCloudApiUnauthorizedExceptionResponse = {
   error: 'CloudApiUnauthorized',
   errorCode: CustomErrorCodes.CloudApiUnauthorized,
-  message: ERROR_MESSAGES.UNAUTHORIZED,
+  message: mockCapiUnauthorizedError.message,
   statusCode: HttpStatus.UNAUTHORIZED,
 };
 
 export const mockCloudApiBadRequestExceptionResponse = {
   error: 'CloudApiBadRequest',
   errorCode: CustomErrorCodes.CloudApiBadRequest,
-  message: ERROR_MESSAGES.BAD_REQUEST,
+  message: mockSmApiBadRequestError.message,
   statusCode: HttpStatus.BAD_REQUEST,
 };

redisinsight/api/test/api/ai/assistant/DELETE-ai-assistant-chats-id.test.ts

@@ -26,13 +26,13 @@ describe('DELETE /ai/assistant/chats/:id', () => {
     {
       name: 'Should return Unauthorized error',
       before: () => {
-        aiAssistantNock.post('/reset').reply(401, { message: 'Unauthorized' })
+        aiAssistantNock.post('/reset').replyWithError({ response: { status: 401 }, message: 'Custom unauthorized message' })
       },
       statusCode: 401,
       responseBody: {
         statusCode: 401,
         error: 'ConvAiUnauthorized',
-        message: 'Authorization failed',
+        message: 'Custom unauthorized message',
         errorCode: 11301,
       },
     },

redisinsight/api/test/api/ai/assistant/GET-ai-assistant-chats-id.test.ts

@@ -47,13 +47,13 @@ describe('GET /ai/assistant/chats/:id', () => {
     {
       name: 'Should return Unauthorized error',
       before: () => {
-        aiAssistantNock.get('/history').reply(401, { message: 'Unauthorized' })
+        aiAssistantNock.get('/history').replyWithError({ response: { status: 401 }, message: 'Custom unauthorized message' })
       },
       statusCode: 401,
       responseBody: {
         statusCode: 401,
         error: 'ConvAiUnauthorized',
-        message: 'Authorization failed',
+        message: 'Custom unauthorized message',
         errorCode: 11301,
       },
     },

redisinsight/api/test/api/ai/assistant/POST-ai-assistant-chats-id-messages.test.ts

@@ -34,7 +34,8 @@ describe('POST /ai/assistant/chats/:id/messages', () => {
     {
       name: 'Should return Unauthorized error',
       before: () => {
-        aiAssistantNock.post('/chat').query(true).reply(401, { message: 'Unauthorized' })
+        aiAssistantNock.post('/chat').query(true)
+          .replyWithError({ message: 'Custom unauthorized message', response: { status: 401 } })
       },
       data: {
         content: mockHumanMessage1Response.content,
@@ -43,7 +44,7 @@ describe('POST /ai/assistant/chats/:id/messages', () => {
       responseBody: {
         statusCode: 401,
         error: 'ConvAiUnauthorized',
-        message: 'Authorization failed',
+        message: 'Custom unauthorized message',
         errorCode: 11301,
       },
     },

redisinsight/api/test/api/ai/assistant/POST-ai-assistant-chats.test.ts

@@ -35,13 +35,13 @@ describe('POST /ai/assistant/chats', () => {
     {
       name: 'Should return Unauthorized error',
       before: () => {
-        aiAssistantNock.post('/auth').reply(401, { message: 'Unauthorized' })
+        aiAssistantNock.post('/auth').replyWithError({ message: 'Custom unauthorized message', response: { status: 401 } })
       },
       statusCode: 401,
       responseBody: {
         statusCode: 401,
         error: 'ConvAiUnauthorized',
-        message: 'Authorization failed',
+        message: 'Custom unauthorized message',
         errorCode: 11301,
       },
     },

redisinsight/api/test/api/cloud/autodiscovery/POST-cloud-autodiscovery-databases.test.ts

@@ -126,7 +126,7 @@ describe('POST /cloud/autodiscovery/databases', () => {
         before: () => {
           nockScope
             .get(`/fixed/subscriptions/${mockImportCloudDatabaseDtoFixed.subscriptionId}/databases/${mockImportCloudDatabaseDtoFixed.databaseId}`)
-            .reply(403, {
+            .replyWithError({
               response: {
                 status: 403,
                 data: { message: 'Unauthorized for this action' },
@@ -143,19 +143,19 @@ describe('POST /cloud/autodiscovery/databases', () => {
         responseBody: [{
           ...mockImportCloudDatabaseDtoFixed,
           status: 'fail',
-          message: ERROR_MESSAGES.FORBIDDEN,
+          message: 'Unauthorized for this action',
           error: {
             statusCode: 403,
             error: 'CloudApiForbidden',
-            message: ERROR_MESSAGES.FORBIDDEN,
+            message: 'Unauthorized for this action',
             errorCode: CustomErrorCodes.CloudApiForbidden,
           },
         }],
       },
       {
         before: () => {
           nockScope.get(`/subscriptions/${mockImportCloudDatabaseDto.subscriptionId}/databases/${mockImportCloudDatabaseDto.databaseId}`)
-            .reply(401, {
+            .replyWithError({
               response: {
                 status: 401,
                 data: '',
@@ -184,7 +184,7 @@ describe('POST /cloud/autodiscovery/databases', () => {
       {
         before: () => {
           nockScope.get(`/subscriptions/${mockImportCloudDatabaseDto.subscriptionId}/databases/${mockImportCloudDatabaseDto.databaseId}`)
-            .reply(404, {
+            .replyWithError({
               response: {
                 status: 404,
                 data: 'Database was not found',

redisinsight/api/test/api/cloud/autodiscovery/POST-cloud-autodiscovery-get_databases.test.ts

@@ -111,7 +111,7 @@ describe('POST /cloud/autodiscovery/get-databases', () => {
       {
         before: () => {
           nockScope.get(`/subscriptions/${mockGetCloudSubscriptionDatabasesDto.subscriptionId}/databases`)
-            .reply(403, {
+            .replyWithError({
               response: {
                 status: 403,
                 data: { message: 'Unauthorized for this action' },
@@ -127,14 +127,14 @@ describe('POST /cloud/autodiscovery/get-databases', () => {
         responseBody: {
           statusCode: 403,
           error: 'CloudApiForbidden',
-          message: ERROR_MESSAGES.FORBIDDEN,
+          message: 'Unauthorized for this action',
           errorCode: CustomErrorCodes.CloudApiForbidden,
         },
       },
       {
         before: () => {
           nockScope.get(`/subscriptions/${mockGetCloudSubscriptionDatabasesDto.subscriptionId}/databases`)
-            .reply(401, {
+            .replyWithError({
               response: {
                 status: 401,
                 data: '',
@@ -157,7 +157,7 @@ describe('POST /cloud/autodiscovery/get-databases', () => {
       {
         before: () => {
           nockScope.get(`/subscriptions/${mockGetCloudSubscriptionDatabasesDto.subscriptionId}/databases`)
-            .reply(404, {
+            .replyWithError({
               response: {
                 status: 404,
                 data: 'Subscription is not found',

redisinsight/api/test/api/cloud/user/PUT-cloud-me-accounts-id-current.test.ts

@@ -71,9 +71,9 @@ describe('PUT /cloud/me/accounts/:id/current', () => {
         before: () => {
           initSMApiNockScope()
             .post(`/accounts/setcurrent/${mockCloudUserAccount.id}`)
-            .reply(401, mockCapiUnauthorizedError)
+            .replyWithError(mockCapiUnauthorizedError)
             .post(`/accounts/setcurrent/${mockCloudUserAccount.id}`)
-            .reply(401, mockCapiUnauthorizedError)
+            .replyWithError(mockCapiUnauthorizedError)
         },
         statusCode: 401,
         checkFn: ({ body }) => {
@@ -85,7 +85,7 @@ describe('PUT /cloud/me/accounts/:id/current', () => {
         before: () => {
           initSMApiNockScope()
             .post(`/accounts/setcurrent/${mockCloudUserAccount.id}`)
-            .reply(400, mockSmApiBadRequestError)
+            .replyWithError(mockSmApiBadRequestError)
         },
         statusCode: 400,
         checkFn: ({ body }) => {