Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be clear what JSON Schema version is supported #129

Closed
lashchev opened this issue Oct 10, 2018 · 5 comments · Fixed by #186
Closed

It should be clear what JSON Schema version is supported #129

lashchev opened this issue Oct 10, 2018 · 5 comments · Fixed by #186
Milestone

Comments

@lashchev
Copy link

Sorry, maybe I am looking in the wrong places, but I cannot find any information on what JSON Schema versions are supported by this extension: draft-04, draft-06, draft-07?

@JPinkney
Copy link
Contributor

I believe its draft-04 though I'll have to check. A lot of the json stuff was able to be re-used from the json language service so it would be whatever that was when I used some of that code.

@lashchev
Copy link
Author

It would be great to document this on the main project page, because json-schema is moving forward and draft-07 is current mainstream for a while now. At least all our schemas are in draft-07.
Draft-08 is coming out soon.

Are there any plans to start supporting draft-07 (Core, Validation, Hyper-Schema, Relative JSON Pointer) any time soon?

@JPinkney
Copy link
Contributor

If I have time then potentially. I work part-time 12 hours per week and am a full-time student so its kind of hard to get to everything when I'm the only one who contributes to this project.

@lashchev
Copy link
Author

@JPinkney Thanks for your effort! Not a lot of free time on my side as well, but in case you need any help or the second pair of eyes - feel free to ping me. I won't promise a prompt reply, but will eventually get to the task)

@andxu
Copy link
Contributor

andxu commented Nov 14, 2018

Hi @lashchev, are you using yaml extension together with this extension https://github.com/Azure/vscode-kubernetes-tools ? if so, the schema is provided by the integrated ones generated by me, https://github.com/Azure/vscode-kubernetes-tools/blob/master/schema/swagger-v1.9.3.json, if it is out of date, please provide a test yaml for me and I will update the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants