Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copies entire project to VSCode workspaceStorage. Doesn't cleanup on Uninstall #984

Open
JonathanShor opened this issue Jul 17, 2019 · 4 comments
Labels

Comments

@JonathanShor
Copy link

Upon opening the single .java file in the repo, this extension (secretly, as far as I'm concerned) copied the entire workspace file tree to VSCode's workspaceStorage. This duplicated 50GB, including (obviously) many files with no relationship to java. Not sure what the rationale for copying every file could be...
but at the very least, clean everything up upon uninstall guys.

Environment
  • Operating System: macOS 10.14.5
  • JDK version: None!
  • Visual Studio Code version: 1.36.1
  • Java extension version: latest
@JonathanShor
Copy link
Author

Related to #960 and #634 maybe?

@fbricon
Copy link
Collaborator

fbricon commented Jul 17, 2019

@JonathanShor this kinda relates to those issues but it's a bit different. When you open a single java file, the language server treats its folder as a java source folder, which is then processed in the language server's workspace (in workspaceStorage). the workspace storage is never cleaned because it's faster to reuse it the next time you reopen your folder.

@testforstephen @yaohaizh we should prolly add some filters to the invisible project source folders. Only process java and properties files, with the possibility of configuring additional file types.

@fbricon
Copy link
Collaborator

fbricon commented Jul 17, 2019

@testforstephen @yaohaizh is there an API to process stuff during extension uninstallation?

@testforstephen
Copy link
Collaborator

testforstephen commented Jul 18, 2019

Looks like there is a thread vscode-45474 to discuss adding an uninstall hook, but it's not supported yet.

@jdneo jdneo added the runtime label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants