Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Display Devfile Icon (Metadata tab) #7072

Closed
2 tasks
rm3l opened this issue Sep 5, 2023 · 0 comments · Fixed by #7078
Closed
2 tasks

[UI] Display Devfile Icon (Metadata tab) #7072

rm3l opened this issue Sep 5, 2023 · 0 comments · Fixed by #7078
Assignees
@feloy
Labels
area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Milestone
v3.15.0 🚀

Comments

@rm3l
Copy link
Member

rm3l commented Sep 5, 2023 •
edited by feloy
Loading

/kind feature
/area Web-UI

Which functionality do you think we should add?

The "Icon" field displays the raw URL. It might make sense to resolve the URL and display the actual icon when possible.

image

cc @ehsavoie

Why is this needed?

  • visually categorize the Devfile

Acceptance criteria

  • display the icon with a standard img tag, next to the input
  • hardcode the size of the img to the same height of the input field
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 5, 2023
@openshift-ci openshift-ci bot added the area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder label Sep 5, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Sep 5, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Sep 6, 2023
@feloy feloy mentioned this issue Sep 8, 2023
Merged
3 tasks
@feloy feloy self-assigned this Sep 8, 2023
@feloy feloy moved this to In Review 👀 in odo Project Sep 8, 2023
@rm3l rm3l added this to the v3.15.0 🚀 milestone Sep 8, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in odo Project Sep 8, 2023
@rm3l rm3l added the priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Projects
odo Project
Archived in project
Milestone
v3.15.0 🚀
Development

Successfully merging a pull request may close this issue.

Display icon in metadata feloy/odo
2 participants
@rm3l @feloy