Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo experimental feature --run-on podman fails with wrong error saying 'unable to access podman' #6501

Closed
dgolovin opened this issue Jan 17, 2023 · 3 comments · Fixed by #6538
Assignees
Labels
area/odo-on-podman Issues or PRs related to running odo against Podman kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Milestone

Comments

@dgolovin
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System: MacOS

Output of odo version: v3.4.0 (b8662ef)

How did you run odo exactly?

  • Installed podman using brew
  • Added podman to PATH
  • odo dev --run-on podman

Actual behavior

odo reports error as ✗ unable to access podman. Do you have podman client installed? see log below

nodejs-ex % ODO_EXPERIMENTAL_MODE=true ~/Sources/vscode-openshift-tools/out/tools/darwin/odo-darwin-amd64 dev --run-on=podman -v 10
I0117 12:31:22.027391   15601 implem.go:109] The path for preference file is /Users/eskimo/.odo/preference.yaml
I0117 12:31:22.027483   15601 util.go:733] HTTPGetRequest: https://raw.githubusercontent.com/redhat-developer/odo/main/build/VERSION
I0117 12:31:22.027523   15601 segment.go:265] Checking telemetry enable status
I0117 12:31:22.027528   15601 segment.go:295] Sending telemetry disabled by preference
I0117 12:31:22.027652   15601 util.go:754] Response will be cached in /var/folders/yz/50s02b8n4yj3_hshg5g6xpz80000gn/T/odohttpcache for 1h0m0s
I0117 12:31:22.028173   15601 util.go:767] Cached response used.
I0117 12:31:22.029192   15601 version.go:28] executing [podman version --format json]
I0117 12:31:22.657304   15601 implem.go:109] The path for preference file is /Users/eskimo/.odo/preference.yaml
Experimental mode enabled for flag: --run-on. Use at your own risk. More details on https://odo.dev/docs/user-guides/advanced/experimental-mode
I0117 12:31:22.660029   15601 context.go:141] absolute devfile path: '/Users/eskimo/Temp/Test1/nodejs-ex/devfile.yaml'
I0117 12:31:22.660055   15601 context.go:92] absolute devfile path: '/Users/eskimo/Temp/Test1/nodejs-ex/devfile.yaml'
I0117 12:31:22.660880   15601 content.go:33] converted devfile YAML to JSON
I0117 12:31:22.661011   15601 apiVersion.go:45] devfile schemaVersion: '2.1.0'
I0117 12:31:22.661042   15601 helper.go:41] devfile apiVersion '2.1.0' is supported
I0117 12:31:22.672108   15601 schema.go:46] validated devfile schema
I0117 12:31:22.675316   15601 validate.go:45] Successfully validated devfile sections
I0117 12:31:22.675455   15601 validate.go:45] Successfully validated devfile sections
I0117 12:31:22.675551   15601 component.go:88] name of component is "nodejs-ex-comp", and sanitized name is "nodejs-ex-comp"
 ✗  unable to access podman. Do you have podman client installed?

Expected behavior

In 3.3.0 release it was reporting correct error, which helped a lot for the first run after podman installed.

nodejs-ex % ODO_EXPERIMENTAL_MODE=true ~/Downloads/odo-330 dev --run-on=podman -v 10                                              
Experimental mode enabled for flag: --run-on. Use at your own risk. More details on https://odo.dev/docs/user-guides/advanced/experimental-mode
I0117 12:12:46.082094   15291 implem.go:109] The path for preference file is /Users/eskimo/.odo/preference.yaml
I0117 12:12:46.082324   15291 util.go:733] HTTPGetRequest: https://raw.githubusercontent.com/redhat-developer/odo/main/build/VERSION
I0117 12:12:46.082361   15291 segment.go:265] Checking telemetry enable status
I0117 12:12:46.082368   15291 segment.go:295] Sending telemetry disabled by preference
I0117 12:12:46.082500   15291 util.go:754] Response will be cached in /var/folders/yz/50s02b8n4yj3_hshg5g6xpz80000gn/T/odohttpcache for 1h0m0s
I0117 12:12:46.083378   15291 util.go:767] Cached response used.
I0117 12:12:46.086813   15291 implem.go:109] The path for preference file is /Users/eskimo/.odo/preference.yaml
I0117 12:12:46.087398   15291 context.go:141] absolute devfile path: '/Users/eskimo/Temp/Test1/nodejs-ex/devfile.yaml'
I0117 12:12:46.087430   15291 context.go:92] absolute devfile path: '/Users/eskimo/Temp/Test1/nodejs-ex/devfile.yaml'
I0117 12:12:46.087619   15291 content.go:33] converted devfile YAML to JSON
I0117 12:12:46.087689   15291 apiVersion.go:45] devfile schemaVersion: '2.1.0'
I0117 12:12:46.087758   15291 helper.go:41] devfile apiVersion '2.1.0' is supported
I0117 12:12:46.091748   15291 schema.go:46] validated devfile schema
I0117 12:12:46.092947   15291 validate.go:45] Successfully validated devfile sections
I0117 12:12:46.092997   15291 validate.go:45] Successfully validated devfile sections
I0117 12:12:46.093077   15291 component.go:86] name of component is "nodejs-ex-comp", and sanitized name is "nodejs-ex-comp"
  __
 /  \__     Developing using the "nodejs-ex-comp" Devfile
 \__/  \    Platform: podman
 /  \__/    odo version: v3.3.0
 \__/

↪ Deploying to podman in developer mode
I0117 12:12:46.093357   15291 utils.go:73] Updating container runtime with mandatory volume mounts
 ✗  Deploying pod [626ms]
 ✗  exit status 125: Cannot connect to Podman. Please verify your connection to the Linux system using `podman system connection list`, or try `podman machine init` and `podman machine start` to manage a new Linux VM
Error: unable to connect to Podman socket: Get "http://d/v4.3.1/libpod/_ping": dial unix ///var/folders/yz/50s02b8n4yj3_hshg5g6xpz80000gn/T/podman-run--1/podman/podman.sock: connect: no such file or directory

Any logs, error output, etc?

See above.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 17, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 17, 2023
@rm3l rm3l added this to odo Project Jan 17, 2023
@kadel kadel added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Jan 18, 2023
@rm3l rm3l added the area/odo-on-podman Issues or PRs related to running odo against Podman label Jan 19, 2023
@rm3l rm3l changed the title odo experimetnal feature --run-on podman fails with wrong error saying 'unable to access podamn' odo experimental feature --run-on podman fails with wrong error saying 'unable to access podman' Jan 19, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 23, 2023
@valaparthvi valaparthvi self-assigned this Jan 24, 2023
@valaparthvi
Copy link
Contributor

@dgolovin would it help if we print the error message in the logs at a higher verbosity level?

@dgolovin
Copy link
Contributor Author

@valaparthvi I understand it is experimental feature, but this kind of errors should appear even w/o -v option, because it shows one the way to fix the error. Current implementation hides it and it takes time to figure out what to do.

@valaparthvi
Copy link
Contributor

@valaparthvi I understand it is experimental feature, but this kind of errors should appear even w/o -v option, because it shows one the way to fix the error. Current implementation hides it and it takes time to figure out what to do.

You're right. It will be better to print it as a part of the error.

@rm3l rm3l added this to the v3.7.0 🚀 milestone Jan 30, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/odo-on-podman Issues or PRs related to running odo against Podman kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants