Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not watch ignored files #5698

Closed
rm3l opened this issue Apr 27, 2022 · 2 comments
Closed

Do not watch ignored files #5698

rm3l opened this issue Apr 27, 2022 · 2 comments
Labels
kind/task Issue is actionable task lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@rm3l
Copy link
Member

rm3l commented Apr 27, 2022

/kind task

Follow-up to a discussion related to #5689

Context

I noticed that while the changes here worked great for sync'ing, we were still unnecessarily watching files that were supposed to be ignored. For example, I saw these logs while testing on a simple multi-module Maven project:

I0426 10:57:01.415897  907437 watch.go:176] adding watch on path /home/asoro/work/tmp/maven-modular/module2/target
I0426 10:57:01.415905  907437 watch.go:176] adding watch on path /home/asoro/work/tmp/maven-modular/module2/target/classes
I0426 10:57:01.415913  907437 watch.go:176] adding watch on path /home/asoro/work/tmp/maven-modular/module2/target/classes/io
I0426 10:57:01.415920  907437 watch.go:176] adding watch on path /home/asoro/work/tmp/maven-modular/module2/target/classes/io/jitpack
I0426 10:57:01.415929  907437 watch.go:176] adding watch on path /home/asoro/work/tmp/maven-modular/module2/target/generated-sources
I0426 10:57:01.415938  907437 watch.go:176] adding watch on path /home/asoro/work/tmp/maven-modular/module2/target/generated-sources/annotations
I0426 10:57:01.415946  907437 watch.go:176] adding watch on path /home/asoro/work/tmp/maven-modular/module2/target/generated-test-sources
I0426 10:57:01.415955  907437 watch.go:176] adding watch on path /home/asoro/work/tmp/maven-modular/module2/target/generated-test-sources/test-annotations

As discussed together, the "watch" part will be fixed in a separate issue/PR.

Originally posted by @rm3l in #5689 (comment)

@openshift-ci openshift-ci bot added the kind/task Issue is actionable task label Apr 27, 2022
@rm3l rm3l added this to odo Project Oct 3, 2022
@rm3l rm3l moved this to To Do 📝 in odo Project Oct 3, 2022
@rm3l rm3l removed the status in odo Project Oct 3, 2022
@kadel kadel added the priority/Medium Nice to have issue. Getting it done before priority changes would be great. label Feb 17, 2023
@github-actions
Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2023
Copy link
Contributor

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Issue is actionable task lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Archived in project
Development

No branches or pull requests

2 participants