Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kuberenetes tests failing #4776

Closed
kadel opened this issue Jun 4, 2021 · 6 comments · Fixed by #4784
Closed

Kuberenetes tests failing #4776

kadel opened this issue Jun 4, 2021 · 6 comments · Fixed by #4784
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@kadel
Copy link
Member

kadel commented Jun 4, 2021 

INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] ginkgo  -mod=vendor -randomizeAllSpecs -slowSpecThreshold=120 -timeout 14400s -nodes=1 -focus="odo project command tests" tests/integration/project/ 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] Failed to compile project: 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube]                     
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] go: inconsistent vendoring in /home/fedora/amqp_ci_rcv_odo-minikube-pr-build_PR_4769/repo: 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] 	github.com/devfile/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/devfile/[email protected] 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] 	sigs.k8s.io/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates sigs.k8s.io/[email protected] 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube]                     
INFO[2021-06-04T06:48:16Z]

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4769/pull-ci-openshift-odo-main-psi-kubernetes-integration-e2e/1400704802039533568

in PR #4769

It looks like something went wrong with VM

/kind testing
/priority high
/kind failing-test
@openshift-ci openshift-ci bot added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). kind/failing-test labels Jun 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 4, 2021

@kadel: The label(s) kind/testing cannot be applied, because the repository doesn't have them.

In response to this:

INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] ginkgo  -mod=vendor -randomizeAllSpecs -slowSpecThreshold=120 -timeout 14400s -nodes=1 -focus="odo project command tests" tests/integration/project/ 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] Failed to compile project: 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube]                     
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] go: inconsistent vendoring in /home/fedora/amqp_ci_rcv_odo-minikube-pr-build_PR_4769/repo: 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] 	github.com/devfile/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates github.com/devfile/[email protected] 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube] 	sigs.k8s.io/[email protected]: is explicitly required in go.mod, but vendor/modules.txt indicates sigs.k8s.io/[email protected] 
INFO[2021-06-04T06:48:16Z] [ssh:Fedora-32-minikube]                     
INFO[2021-06-04T06:48:16Z]

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4769/pull-ci-openshift-odo-main-psi-kubernetes-integration-e2e/1400704802039533568

in PR #4769

It looks like something went wrong with VM

/kind testing
/priority high
/kind failing-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel kadel added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Jun 4, 2021
@kadel
Copy link
Member Author

kadel commented Jun 8, 2021 •
edited
Loading

after cleaning go mod cache go clean -modcache it fails on

[root@bfb4ae73fc20 odo]# make
verifying github.com/mikefarah/yaml/[email protected]/go.mod: checksum mismatch
	downloaded: h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
	go.sum:     h1:ahVqZF4n1W4NqwvVnZzC4es67xsW9uR/RRf2RRxieJU=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.
go build -mod=vendor -ldflags="-X github.com/openshift/odo/pkg/version.GITCOMMIT=a54cfd86d" cmd/odo/odo.go

Interesting is that copy/pasting build command go build -mod=vendor -ldflags="-X github.com/openshift/odo/pkg/version.GITCOMMIT=a54cfd86d" cmd/odo/odo.go exectued by make makes it build sucesfully

I was able to reproduce this only on Fedora systems. On my local Arch Linux or inside Ubuntu container everything works ok.
Go version doesn't seem to have an effect on this.

  • jenkins-minkube VM is using go1.14 - fails
  • my local system using go1.16 and 1.14 and 1.13 all without problems
  • ubuntu in a container using go1.16 no problems
  • fedora in container using go1.16 fails

@kadel
Copy link
Member Author

kadel commented Jun 8, 2021

Interesting is that copy/pasting build command go build -mod=vendor -ldflags="-X github.com/openshift/odo/pkg/version.GITCOMMIT=a54cfd86d" cmd/odo/odo.go exectued by make makes it build sucesfully

it looks like that for some reason when the command is executed using make it ignores -mod=vendor that's why it fails on checksum mismatch

@valaparthvi valaparthvi mentioned this issue Jun 8, 2021
Merged
5 tasks
@kadel kadel mentioned this issue Jun 8, 2021
Merged
5 tasks
@valaparthvi valaparthvi mentioned this issue Jun 8, 2021
Merged
5 tasks
@kadel
Copy link
Member Author

kadel commented Jun 8, 2021

It was failing when something got changes in vendor.
The reason for failure was that go list in

PKGS := $(shell go list  ./... | grep -v $(PROJECT)/vendor | grep -v $(PROJECT)/tests)

was not using -mod=vedor
the same for ginkgo commands

fix: #4784

@prietyc123
Copy link
Contributor

We are still facing this issue on fedora machine https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4754/pull-ci-openshift-odo-main-psi-kubernetes-integration-e2e/1402613266974248960#1:build-log.txt%3A174

@prietyc123 prietyc123 reopened this Jun 10, 2021
@prietyc123
Copy link
Contributor

duplicate of issue #4726

@prietyc123 prietyc123 mentioned this issue Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use -mod=vendor with all go commands in Makefile and use vendoring to manage ginkgo kadel/odo
2 participants
@kadel @prietyc123