Inconsistency between odo registry output and preference.yaml

[kadel]

#4525 introduced support for the new OCI registry and a migration path to it.

Problem is that it also creates inconsistency between what odo registry list shows and what is in preference.yaml.

Ideally, odo should change the preference file as well and store the new registry URL there.

▶ odo registry list
NAME                       URL                                                       SECURE
demo                       https://raw.githubusercontent.com/kadel/registry/demo     No
DefaultDevfileRegistry     https://registry.devfile.io                               No

▶ cat ~/.odo/preference.yaml
kind: Preference
apiversion: odo.dev/v1alpha1
OdoSettings:
  BuildTimeout: 5
  RegistryList:
  - Name: DefaultDevfileRegistry
    URL: https://github.com/odo-devfiles/registry
    secure: false
  - Name: demo
    URL: https://raw.githubusercontent.com/kadel/registry/demo
    secure: false
  ConsentTelemetry: false

[dharmit]

▶ odo registry list
NAME                       URL                                                       SECURE
demo                       https://raw.githubusercontent.com/kadel/registry/demo     No
DefaultDevfileRegistry     https://registry.devfile.io                               No

▶ cat ~/.odo/preference.yaml
kind: Preference
apiversion: odo.dev/v1alpha1
OdoSettings:
  BuildTimeout: 5
  RegistryList:
  - Name: DefaultDevfileRegistry
    URL: https://github.com/odo-devfiles/registry
    secure: false
  - Name: demo
    URL: https://raw.githubusercontent.com/kadel/registry/demo
    secure: false
  ConsentTelemetry: false

What I'm seeing is:

❯ cat ~/.odo/preference.yaml
kind: Preference
apiversion: odo.dev/v1alpha1
OdoSettings:
  NamePrefix: dharmit
  BuildTimeout: 3000
  PushTimeout: 480
  RegistryList:
  - Name: DefaultDevfileRegistry
    URL: https://raw.githubusercontent.com/odo-devfiles/registry/master
    secure: false
  Ephemeral: true
  ConsentTelemetry: false

❯ odo registry list         
NAME                       URL                             SECURE
DefaultDevfileRegistry     https://registry.devfile.io     No

The inconsistency I see there is that odo registry list shows only https://registry.devfile.io while preference.yaml has https://raw.githubusercontent.com/odo-devfiles/registry/master.

[dharmit]

@kadel how does this work? I don't see GH registry in odo registry list wheras registry.devfile.io doesn't show up in ~/.odo/preference.yaml.

So, is registry.devfile.io hardcoded into odo now? Reference change in PR.

How can "we" (as in through some PR) change this inconsistency? From what I understand, it would require one to manually edit the preference.yaml file.

Am I missing something here?

[kadel]

@kadel how does this work? I don't see GH registry in odo registry list wheras registry.devfile.io doesn't show up in ~/.odo/preference.yaml.

If DefaultDevfileRegistry in the preference file is not the new registry.devfile.io it changes it to it.
So the rest of the code is using the new address.
But it does this only "in-memory" without actually updating preference file.

https://github.com/openshift/odo/blob/1156a13b4e28ca5fdc886197a8ef45bfa94be777/pkg/preference/preference.go#L253-L261

How can "we" (as in through some PR) change this inconsistency? From what I understand, it would require one to manually edit the preference.yaml file.

odo should update the preference file instead of just during it just "in-memory" every time.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.