Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about "odo project" set of commands running against a cluster #4442

Closed
dharmit opened this issue Feb 17, 2021 · 3 comments · Fixed by #4528
Closed

Be explicit about "odo project" set of commands running against a cluster #4442

dharmit opened this issue Feb 17, 2021 · 3 comments · Fixed by #4528
Assignees
Labels
good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo

Comments

@dharmit
Copy link
Member

dharmit commented Feb 17, 2021

What versions of software are you using?

Operating System: all

Output of odo version: master

How did you run odo exactly?

Ran set of odo project commands:

  • odo project create -h
  • odo project delete -h
  • odo project set -h

Actual behavior

None of the help messages clearly indicate that they will be run against a kubernetes cluster.

Expected behavior

Help messages should be clear because odo does most things with "create+push" workflow wherein cluster resources are created only when odo push is executed. For commands that would do things on a cluster without odo push, this should be clear from help message

/good-first-issue
/area project
/kind bug

@openshift-ci-robot
Copy link
Collaborator

@dharmit:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

What versions of software are you using?

Operating System: all

Output of odo version: master

How did you run odo exactly?

Ran set of odo project commands:

  • odo project create -h
  • odo project delete -h
  • odo project set -h

Actual behavior

None of the help messages clearly indicate that they will be run against a kubernetes cluster.

Expected behavior

Help messages should be clear because odo does most things with "create+push" workflow wherein cluster resources are created only when odo push is executed. For commands that would do things on a cluster without odo push, this should be clear from help message

/good-first-issue
/area project
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added area/project kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 17, 2021
@girishramnani
Copy link
Contributor

A help message like - this command directly performs actions on the cluster and doesn't require a push?

@dharmit
Copy link
Member Author

dharmit commented Mar 17, 2021

Yeah that would do.

@girishramnani girishramnani self-assigned this Mar 18, 2021
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
@rm3l rm3l added this to odo Project Jun 16, 2023
@rm3l rm3l moved this to Done ✅ in odo Project Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants