Minor error handling changes

Author: rnc

Diff for: osia/cli.py

@@ -189,7 +189,7 @@ def _setup_parser():
 
 def main_cli():
     """Function represents main entrypoint for the
-    osia intaller
+    osia installer
 
     It sets up the cli and starts the executor."""
     parser = _setup_parser()

Diff for: osia/config/config.py

@@ -41,7 +41,7 @@ def _resolve_cloud_name(args: argparse.Namespace) -> Optional[Dict]:
     for env in defaults['CLOUD'][args.cloud]['environments']:
         if env['name'] == default_env:
             return env
-    logging.debug("No environment found, maybe all variables are passed from command line")
+    logging.warning("No environment found, maybe all variables are passed from command line")
     return None
 
 

Diff for: osia/installer/downloader/install.py

@@ -150,5 +150,5 @@ def download_installer(installer_version: str,
     if root.exists() and root.joinpath('openshift-install').exists():
         logging.info('Found installer at %s', root.as_posix())
         return root.joinpath('openshift-install').as_posix()
-    root.mkdir(parents=True)
+    root.mkdir(parents=True, exist_ok=True)
     return get_installer(url, root.as_posix())

Diff for: osia/installer/storage.py

@@ -33,11 +33,12 @@ def check_repository():
     current tracking branch."""
     rep = Repo("./")
     remote = rep.active_branch.tracking_branch()
-    fetches = rep.remotes[remote.remote_name].fetch()
-    for fetch in fetches:
-        if fetch.name == remote.name and fetch.commit != rep.commit():
-            logging.warning("There are changes in remote repository, trying to pull")
-            rep.remotes[remote.remote_name].pull()
+    if remote:
+        fetches = rep.remotes[remote.remote_name].fetch()
+        for fetch in fetches:
+            if fetch.name == remote.name and fetch.commit != rep.commit():
+                logging.warning("There are changes in remote repository, trying to pull")
+                rep.remotes[remote.remote_name].pull()
     if rep.is_dirty():
         logging.warning("There are not committed changes in your repository, please fix this")
 
@@ -52,8 +53,8 @@ def write_changes(cluster_directory):
     rep.index.add(cluster_directory)
     logging.info("Commiting installer changes for cluster %s", cluster_directory)
     rep.index.commit(f"[OCP Installer] installation files for {cluster_directory} added")
-
-    rep.remotes[remote.remote_name].push()
+    if remote:
+        rep.remotes[remote.remote_name].push()
 
 
 def delete_directory(cluster_directory):
@@ -63,4 +64,5 @@ def delete_directory(cluster_directory):
     logging.info("Removing cluster directory from git repository %s", cluster_directory)
     rep.index.remove(cluster_directory, working_tree=True, r=True, f=True)
     rep.index.commit(f"[OCP Installer] removed installation files for {cluster_directory}")
-    rep.remotes[remote.remote_name].push()
+    if remote:
+        rep.remotes[remote.remote_name].push()