Skip to content

Commit 48b9d25

Browse files
committed
Fix pylint issues
1 parent 481fe82 commit 48b9d25

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

Diff for: osia/installer/clouds/base.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,10 @@ def get_apps_ip(self):
9595

9696
def _resolve_version(self):
9797
if self.ocp_version is None:
98-
capture = run([self.installer, "version"], capture_output=True)
98+
capture = run([self.installer, "version"], capture_output=True, check=False)
9999
ver_string = capture.stdout.decode("utf-8").splitlines()[0].split(' ')[1]
100100
self.ocp_version = ver_string
101-
logging.info(f"Resolved installed version as {self.ocp_version}")
101+
logging.info("Resolved installed version as %s", self.ocp_version)
102102

103103
def _resolve_network_type(self):
104104
self._resolve_version()

Diff for: pylintrc

+4-3
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ disable=raw-checker-failed,
7373
unused-private-member,
7474
missing-timeout,
7575
unnecessary-dunder-call,
76-
use-dict-literal
76+
use-dict-literal,
77+
broad-exception-raised #TODO fix this in next release
7778

7879
# Enable the message, report, category or checker with the given id(s). You can
7980
# either give multiple identifier separated by comma (,) or put this option
@@ -506,5 +507,5 @@ valid-metaclass-classmethod-first-arg=cls
506507

507508
# Exceptions that will emit a warning when being caught. Defaults to
508509
# "BaseException, Exception".
509-
overgeneral-exceptions=BaseException,
510-
Exception
510+
overgeneral-exceptions=builtins.BaseException,
511+
builtins.Exception

0 commit comments

Comments
 (0)