From 0c177cd071a0b644ab9a6b5bd0dd375f1b21389a Mon Sep 17 00:00:00 2001 From: Rohit Thakur Date: Fri, 1 Dec 2023 17:47:10 +0530 Subject: [PATCH 1/2] Update README.md (#21) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 675cfaa..8acecf3 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Network OSPF Validated Content [![CI](https://github.com/redhat-cop/network.ospf/actions/workflows/tests.yml/badge.svg?event=schedule)](https://github.com/redhat-cop/network.ospf/actions/workflows/tests.yml) -[![OpenSSF Best Practices](https://bestpractices.coreinfrastructure.org/projects/7404/badge)](https://bestpractices.coreinfrastructure.org/projects/7404) +[![OpenSSF Best Practices](https://bestpractices.coreinfrastructure.org/projects/7662/badge)](https://bestpractices.coreinfrastructure.org/projects/7662) This repository contains the `network.ospf` Ansible Collection. From 15856310443e15efdc7f5e22fff8bc35e4c98718 Mon Sep 17 00:00:00 2001 From: Sagar Paul Date: Fri, 1 Dec 2023 17:47:47 +0530 Subject: [PATCH 2/2] fix lint workflow, update reference (#23) * fix lint workflow, update reference * Update .github/workflows/lint.yml * Update .github/workflows/lint.yml --------- Co-authored-by: Rohit Thakur --- .ansible-lint | 6 ++++++ .config/ansible-lint.yml | 3 --- .github/workflows/lint.yml | 13 +++++++++++++ .github/workflows/tests.yml | 8 ++------ changelogs/fragments/.keep | 0 changelogs/fragments/trivial_lint.yaml | 3 +++ 6 files changed, 24 insertions(+), 9 deletions(-) create mode 100644 .ansible-lint delete mode 100644 .config/ansible-lint.yml create mode 100644 .github/workflows/lint.yml create mode 100644 changelogs/fragments/.keep create mode 100644 changelogs/fragments/trivial_lint.yaml diff --git a/.ansible-lint b/.ansible-lint new file mode 100644 index 0000000..5f51d1f --- /dev/null +++ b/.ansible-lint @@ -0,0 +1,6 @@ +--- +profile: production +exclude_paths: + - changelogs/changelog.yaml +skip_list: + - var-naming[no-role-prefix] diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml deleted file mode 100644 index ccb44f5..0000000 --- a/.config/ansible-lint.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -skip_list: - - var-naming[no-role-prefix] # this rule error out correct vars names for network validated content. diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml new file mode 100644 index 0000000..fbac38c --- /dev/null +++ b/.github/workflows/lint.yml @@ -0,0 +1,13 @@ +--- +name: ansible-lint +on: # yamllint disable-line rule:truthy + pull_request: + branches: ["main"] +jobs: + build: + name: Ansible Lint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Run ansible-lint + uses: ansible/ansible-lint@main diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3f96d66..f42dd9f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -5,16 +5,14 @@ concurrency: group: ${{ github.head_ref || github.run_id }} cancel-in-progress: true -on: # yamllint disable-line rule:truthy +on: # yamllint disable-line rule:truthy pull_request: branches: [main] workflow_dispatch: schedule: - - cron: '0 0 * * *' + - cron: "0 0 * * *" jobs: - ansible-lint: - uses: ansible-network/github_actions/.github/workflows/ansible-lint.yml@main changelog: uses: ansible-network/github_actions/.github/workflows/changelog.yml@main if: github.event_name == 'pull_request' @@ -94,7 +92,6 @@ jobs: all_green: if: ${{ always() && (github.event_name != 'schedule') }} needs: - - ansible-lint - changelog - sanity runs-on: ubuntu-latest @@ -104,7 +101,6 @@ jobs: - run: >- python -c "assert 'failure' not in set([ - '${{ needs.ansible-lint.result }}', '${{ needs.changelog.result }}', '${{ needs.sanity.result }}', ])" diff --git a/changelogs/fragments/.keep b/changelogs/fragments/.keep new file mode 100644 index 0000000..e69de29 diff --git a/changelogs/fragments/trivial_lint.yaml b/changelogs/fragments/trivial_lint.yaml new file mode 100644 index 0000000..744f363 --- /dev/null +++ b/changelogs/fragments/trivial_lint.yaml @@ -0,0 +1,3 @@ +--- +trivial: + - "Fix lint action reference."