Webpack 2 #355
Webpack 2 #355
Conversation
| @@ -36,8 +36,8 @@ | |||
| "eslint-plugin-import": "^1.15.0", | |||
| "eslint-plugin-jsx-a11y": "^2.2.2", | |||
| "eslint-plugin-react": "^6.2.1", | |||
| "extract-text-webpack-plugin": "^1.0.1", | |||
| "file-loader": "^0.9.0", | |||
| "extract-text-webpack-plugin": "grrowl/extract-text-webpack-plugin#order-undefined-error", | |||
There was a problem hiding this comment.
This fork allows ignoring the undefined order of our CSS modules. We should fix this at its root cause but it's not entirely clear how to do that at the moment: webpack-contrib/extract-text-webpack-plugin#166
There was a problem hiding this comment.
The "Order in extracted chunk" errors have decreased, but not gone. There were 44 and there are now 12. They all flag up against the same file ./site/components/header/style.css
There was a problem hiding this comment.
The point is that they don't fail the build with this fork. I did try and correct the issue in header/style.css but didn't make much progress. Practically, it won't matter unless there are styles with exactly the same level of specificity being generated in a non-deterministic order.
| @@ -36,8 +36,8 @@ | |||
| "eslint-plugin-import": "^1.15.0", | |||
| "eslint-plugin-jsx-a11y": "^2.2.2", | |||
| "eslint-plugin-react": "^6.2.1", | |||
| "extract-text-webpack-plugin": "^1.0.1", | |||
| "file-loader": "^0.9.0", | |||
| "extract-text-webpack-plugin": "grrowl/extract-text-webpack-plugin#order-undefined-error", | |||
There was a problem hiding this comment.
The "Order in extracted chunk" errors have decreased, but not gone. There were 44 and there are now 12. They all flag up against the same file ./site/components/header/style.css
| { allChunks: true } | ||
| ), | ||
| new webpack.LoaderOptionsPlugin({ options: { context: __dirname, postcss: [autoprefixer] } }), | ||
| new ExtractTextPlugin({ allChunks: true, filename: 'assets-honestly/styles-[contenthash:base64:5].css', ignoreOrder: true }), |
There was a problem hiding this comment.
This same ExtractTextPlugin change needs to go in webpack.dev.browser.config.js
There was a problem hiding this comment.
Ah yes - I won't be able to work on this today though.
|
Closing this one for now as it is stale. Feel free to re-open. |
Motivation
Webpack 2 has now been released, it contains a number of nice new features. One feature we're not yet taking advantage of is tree shaking.
Unfortunately, most modules we depend upon are currently using CommonJS module syntax, not ES6 syntax, this means we only save 2.2% on the bundle with tree shaking enabled, this should increase a lot in the future.
Test plan
Pre-merge checklist