Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging to main: fix tests and update documentation #1940

Merged
merged 45 commits into from
Jun 9, 2023
Merged

Staging to main: fix tests and update documentation #1940

merged 45 commits into from
Jun 9, 2023

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

miguelgfierro and others added 30 commits April 21, 2023 15:25
@miguelgfierro
dev
2c9fdb3
@miguelgfierro
dev
3068f43
@miguelgfierro
🐛
9b0a332
@miguelgfierro
📝
0f56274
@miguelgfierro
Update SETUP.md
3743375
@wutaomsft
Merge pull request #1923 from microsoft/readme_dev
9edd7f6 
Add a section in the readme for developers
@miguelgfierro
Refact dev setup
0c5c842
@miguelgfierro
Refact dev setup
94e8924
@miguelgfierro
Refact dev setup
b1bb888
@wutaomsft
Merge pull request #1926 from microsoft/miguel/dev_setup
bd39aaa 
Setup development
@miguelgfierro
Restricting cornac to 1.15.1
dc64de0
@miguelgfierro
Remove azure cosmos
fa2abba
@miguelgfierro
restrict cornac
584c4ec
@miguelgfierro
Clarification cornac
cc8edd1
@miguelgfierro
Install the development environment instead of the pip package
fce46cc
@miguelgfierro
Install the development environment instead of the pip package
4938e38
@miguelgfierro
Install the development environment instead of the pip package
7a69fba
@miguelgfierro
Install the development environment instead of the pip package
21460e5
@miguelgfierro
Install the development environment instead of the pip package
71bcd8f
@miguelgfierro
Install the development environment instead of the pip package
643d81b
@miguelgfierro
Try with interpreter options
6960cb5
@miguelgfierro
cornac
e18a4be
@miguelgfierro
WIP
81c2bce
@miguelgfierro
Try building dockerfile
21b519b
@miguelgfierro
Error with spark and gpu excluded tests
a4adec9
@miguelgfierro
Error with spark and gpu excluded tests
cdaeb7a
@miguelgfierro
Error with spark and gpu excluded tests
5f80758
@miguelgfierro
Error with spark and gpu excluded tests
1c73cfb
@simonzhaoms
Try to install the local wheel of recommenders
be68442
@simonzhaoms
Change pip install scheme
67c6d25
miguelgfierro and others added 15 commits June 7, 2023 12:35
@miguelgfierro
Remove bottleneck dep
7e548f4
@simonzhaoms
Test normal usage of Environment.add_private_pip_wheel()
754e428
@simonzhaoms
Install recommenders from GitHub
28cdedc
@simonzhaoms
Clean up
caf7192
@miguelgfierro
Merge pull request #1934 from microsoft/miguel/bug_cornac_numpy
58753b6 
Restricting cornac to 1.15.1 for issue with 1.15.4
@miguelgfierro
Numpy with the same version
655709c
@miguelgfierro
Merge branch 'staging' into miguelgfierro-patch-1
a2b76de
@miguelgfierro
Merge branch 'staging' into miguelgfierro-patch-2
febb5a6
@miguelgfierro
Merge pull request #1935 from microsoft/miguelgfierro-patch-1
679e80b 
Remove azure cosmos
@miguelgfierro
less deps
24b0174
@miguelgfierro
less deps
a6c0ad1
@miguelgfierro
less deps
dc02a24
@miguelgfierro
Adding back tf slim
88a9325
@miguelgfierro
Merge pull request #1939 from microsoft/miguel/non-essential-deps
0e67e29 
Remove non essential deps
@miguelgfierro
Merge pull request #1938 from microsoft/miguelgfierro-patch-2
3cea4d5 
Remove bottleneck dep
@miguelgfierro miguelgfierro merged commit 787ae30 into main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonzhaoms simonzhaoms simonzhaoms approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelgfierro @simonzhaoms @wutaomsft