Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Pipeline Fixes #1545

Merged
merged 7 commits into from
Oct 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/.codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,8 @@
# For more details, please see:
# https://docs.codecov.com/docs/pull-request-comments#section-behavior
comment:
behavior: new
behavior: default

flags:
nightly:
joined: false
1 change: 1 addition & 0 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ jobs:
- name: Upload code coverage report to CodeCov
uses: codecov/[email protected]
with:
flags: nightly
fail_ci_if_error: true
# comes from the last 'Merge coverage reports' step
files: ./coverage.xml
16 changes: 16 additions & 0 deletions .github/workflows/pr-gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 2

- name: Setup Python
uses: actions/setup-python@v2
with:
Expand All @@ -63,6 +66,18 @@ jobs:
continue-on-error: true
run: |
tox -e flake8

- name: Detect changes in 'setup.py'
id: setup-dot-py-changes
uses: tj-actions/changed-files@v10
with:
files: setup.py

- name: Raise notice for changes in 'setup.py'
# Throws a notice for new release if there are changes in 'setup.py'
if: steps.setup-dot-py-changes.outputs.any_changed == 'true'
run:
echo "::notice file=setup.py,line=1,title=A new release may be needed::Changes detected in 'setup.py'. Please examine if a new release on PyPI is needed."

###############################################
################## CPU-BUILD ##################
Expand Down Expand Up @@ -209,6 +224,7 @@ jobs:
- name: Upload code coverage report to CodeCov
uses: codecov/[email protected]
with:
flags: pr-gate
fail_ci_if_error: true
# comes from the last 'Merge coverage reports' step
files: ./coverage.xml
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
"pytest>=3.6.4",
"pytest-cov>=2.12.1",
"pytest-mock>=3.6.1", # for access to mock fixtures in pytest
"pytest-rerunfailures>=10.2", # to mark flaky tests
],
}
# for the brave of heart
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/examples/test_notebooks_pyspark.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
from recommenders.utils.constants import DEFAULT_RATING_COL, DEFAULT_USER_COL, DEFAULT_ITEM_COL


# This is a flaky test that can fail unexpectedly
@pytest.mark.flaky(reruns=3, reruns_delay=2)
@pytest.mark.notebooks
@pytest.mark.spark
@pytest.mark.skipif(
Expand Down Expand Up @@ -74,6 +76,8 @@ def test_evaluation_diversity_runs(notebooks, output_notebook, kernel_name):
))


# This is a flaky test that can fail unexpectedly
@pytest.mark.flaky(reruns=3, reruns_delay=2)
@pytest.mark.notebooks
@pytest.mark.spark
@pytest.mark.skipif(
Expand Down