Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Player Support #1420

Closed
2 tasks done
TheAymen opened this issue Dec 8, 2024 · 5 comments
Closed
2 tasks done

External Player Support #1420

TheAymen opened this issue Dec 8, 2024 · 5 comments
Labels
enhancement New feature or request possible duplicate Assigned by the bot

Comments

@TheAymen
Copy link

TheAymen commented Dec 8, 2024

Describe your suggested feature

First of all, thank you for all the great work.

Currently, there is no simple way to do this on android tv other than copying the link and pasting it on the external player. Why limit the options to a few select ones when you can have them all as external players?

Some say that "open in browser" works, and perhaps it does so on phone, but doesn't really work on my Chromecast with Google TV. It just opens the browser and doesn't show me the option to select other apps as other posts seem to suggest.

Thanks.

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
@TheAymen TheAymen added the enhancement New feature or request label Dec 8, 2024
@recloudstream
Copy link
Contributor

recloudstream bot commented Dec 8, 2024

Your issue looks similar to these issues:

Please close if duplicate.

  1. 66% Torrent stream  #1385

🤖 By issues-similarity-analysis

@recloudstream recloudstream bot added the possible duplicate Assigned by the bot label Dec 8, 2024
@fire-light42
Copy link
Collaborator

What external players are missing? We are only natively supporting open source video players out of principle, however if there are some popular open source video players that are missing then we can add it. Moreover extensions have the ability to add more video players options, so you or anyone else can add it without doing a PR.

@TheAymen
Copy link
Author

TheAymen commented Dec 8, 2024

Thank you for the reply.

Unfortunately, the players I normally use aren't open-source. My suggestion would be something like an "external" option that allows any app installed capable of playing the content/links to play the content, rather than explicitly supporting each new player.

Similar to how the "Open in Browser" option lets you choose your browser if you have multiple installed.

Regarding the extension that supports external players, I haven't come across such, and it would certainly be useful. Are you aware of any specific projects that have achieved this?

Thanks.

@asl97
Copy link

asl97 commented Dec 9, 2024

I mentioned "share link" before on numerous occasions.

Here is the share link feature on firefox, it contain almost everything anyone might want and also a lot of irrelevant apps but that's fine.
Screenshot_2024-12-09-11-49-20-493_android

Cloudstream also has the share feature implement for sharing the show page but not for the individual episode.
Screenshot_2024-12-09-12-05-19-904_com mi android globallauncher-edit

@fire-light42 would it be that hard to either change "Copy to Clipboard" to "Share Link" or just add "Share Link" as another as another option using what was already implemented for the page share?

I am guessing just swap the clipboard line

with the share intent lines and changing a few variable names.

try {
val i = Intent(Intent.ACTION_SEND)
i.type = "text/plain"
i.putExtra(Intent.EXTRA_SUBJECT, d.title)
i.putExtra(Intent.EXTRA_TEXT, d.url)
startActivity(Intent.createChooser(i, d.title))
} catch (e: Exception) {
logError(e)
}

past requests:
#747 (comment)
#899 (comment)

@fire-light42
Copy link
Collaborator

ACTION_SEND is not the same as ACTION_VIEW. And Open in browser uses ACTION_VIEW meaning that is up to the receiving apps to declare that they can handle showing that media, however ACTION_SEND means that we "Deliver some data to someone else". Video links are by their very definition only for you (some are even ip locked), so it makes no sense for us to "share" links because some other app has not declared a valid ACTION_VIEW.

https://github.com/recloudstream/cloudstream/blob/master/app/src/main/java/com/lagradost/cloudstream3/actions/temp/PlayInBrowserAction.kt#L35

https://developer.android.com/reference/android/content/Intent#ACTION_VIEW
https://developer.android.com/reference/android/content/Intent#ACTION_SEND

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request possible duplicate Assigned by the bot
Projects
None yet
Development

No branches or pull requests

3 participants