-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Argument to Exclude SubQuery Column Node in Column Lineage Path #526
Comments
It's not a bug. Column lineage is defined as a path , instead of source * target column tuple. The variable name exclude_subquery is misleading though. It merely means by default we want to exclude the column lineage path ending with column in subquery. And get_column_lineage returns We will not change the logic. But let me know if you're interested in getting the document right. |
临时表包括CTE,是加工过程中的临时变量。对于血缘展现和分析是不需要。 The temporary table includes CTE, which is a temporary variable during processing. It is not required for lineage display and analysis. In addition, table blood relations do not display temporary tables, so why should field blood relations display temporary tables? If there is, it should be there, if not there should be none. |
那我如果补充个方法, 实现 column lineage 的 Tuple[List[Column, Column]] 是不是也可以解决问题? |
Actually we have request to expose subquery at table level lineage, though personally I'm not taking that as high priority due to the fact that SubQuery cannot be added to table lineage very easily that it probably requires changes in current graph modeling. You can check details in #192 . Regarding table vs column lineage, we have two very different APIs:
They're not comparable, unless we build a If we really want to do this, I think instead of adding another method, we should add a new argument to get_column_lineage:
And document them clearly. |
Describe the bug
now get_column_lineage's result include SubQuery
To Reproduce
For example:
Expected behavior
Python version (available via
python --version
)SQLLineage version (available via
sqllineage --version
):Additional context
I will submit a PR later
The text was updated successfully, but these errors were encountered: