Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce sqlparse only test cases #347

Closed
reata opened this issue Mar 26, 2023 · 4 comments · Fixed by #414
Closed

Reduce sqlparse only test cases #347

reata opened this issue Mar 26, 2023 · 4 comments · Fixed by #414
Labels
enhancement New feature or request

Comments

@reata
Copy link
Owner

reata commented Mar 26, 2023

With v1.4.0, we introduce two parser implementations, namely sqlparse and sqlfluff. We run dual test using both parser and make sure the lineage result is exactly the same. But there're exceptions.

This issue is just to document all the test cases where sqlparse is the only option. They fail because sqlfluff fails to parse them. We'd like to reduce this list first by submitting issues to sqlfluff to solve these edge case.

test case dialect
test_create_using_serde hive
test_copy_into_path tsql
test_select_from_unnest_with_ordinality athena

In long term, as a validating and dialect-awareness parser, we'd like to ramp up usage of sqlfluff, bring it to the same level of capability, then gradually add cases where sqlfluff is the only option until ultimately get sqlparse removed.

@reata reata added the enhancement New feature or request label Mar 26, 2023
@reata
Copy link
Owner Author

reata commented Jul 19, 2023

test_copy_into_path of tsql PR submitted: sqlfluff/sqlfluff#4985

@reata
Copy link
Owner Author

reata commented Jul 22, 2023

test_create_using_serde of hive is actually parsable with sqlfluff. We had character escaping issue in the test sql previously. This is now fixed via #413

@reata
Copy link
Owner Author

reata commented Jul 22, 2023

test_select_from_unnest_with_ordinality of athena PR submitted: sqlfluff/sqlfluff#4991

@reata
Copy link
Owner Author

reata commented Jul 26, 2023

All PR merged and released via https://github.com/sqlfluff/sqlfluff/releases/tag/2.1.4 and https://github.com/sqlfluff/sqlfluff/releases/tag/2.1.3.

We should be able to solve this by upgrading to sqlfluff v2.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant