refactor: use as few condition as possible: SQLLineageConfig.LATERAL_COLUMN_ALIAS_REFERENCE

Author: maoxingda

sqllineage/core/models.py

@@ -224,10 +224,7 @@ def _to_src_col(
                 if src_col == "*":
                     # select *
                     i = 0
-                    if (
-                        SQLLineageConfig.LATERAL_COLUMN_ALIAS_REFERENCE
-                        and holder is not None
-                    ):
+                    if holder is not None:
                         for sq in subqueryies:
                             columns = holder.get_table_columns(sq)
                             if columns:
@@ -241,18 +238,14 @@ def _to_src_col(
                     # select unqualified column
                     source = _to_src_col(src_col, None)
                     is_find = False
-                    if (
-                        SQLLineageConfig.LATERAL_COLUMN_ALIAS_REFERENCE
-                        and holder is not None
-                    ):
-                        for sq in subqueryies:
-                            for column in holder.get_table_columns(sq):
-                                if column.raw_name == src_col:
-                                    source = _to_src_col(src_col, sq)
-                                    is_find = True
-                                    break
-                            if is_find:
+                    for sq in subqueryies:
+                        for column in holder.get_table_columns(sq):
+                            if column.raw_name == src_col:
+                                source = _to_src_col(src_col, sq)
+                                is_find = True
                                 break
+                        if is_find:
+                            break
                     if is_find is False:
                         setattr(source, "has_qualifier", False)
                         for table in set(alias_mapping.values()):

sqllineage/core/parser/__init__.py

@@ -88,11 +88,11 @@ def end_of_query_cleanup(self, holder: SubQueryLineageHolder) -> None:
                                                 lateral_alias_col, tgt_col
                                             )
                                         break
-                            if tgt_col.raw_name == "*":
-                                expand_tgt_col = Column(src_col.raw_name)
-                                expand_tgt_col.parent = tgt_tbl
-                                holder.add_column_lineage(src_col, expand_tgt_col)
-                                continue
+                        if tgt_col.raw_name == "*":
+                            expand_tgt_col = Column(src_col.raw_name)
+                            expand_tgt_col.parent = tgt_tbl
+                            holder.add_column_lineage(src_col, expand_tgt_col)
+                            continue
                         if is_lateral_alias_ref:
                             continue
                         holder.add_column_lineage(src_col, tgt_col)

sqllineage/core/parser/sqlfluff/extractors/base.py

@@ -4,7 +4,6 @@
 
 from sqlfluff.core.parser import BaseSegment
 
-from sqllineage.config import SQLLineageConfig
 from sqllineage.core.holders import SubQueryLineageHolder
 from sqllineage.core.metadata_provider import MetaDataProvider
 from sqllineage.core.models import Path, SubQuery, Table
@@ -226,11 +225,7 @@ def extract_subquery(
                 self.dialect, self.metadata_provider
             ).extract(sq.query, AnalyzerContext(cte=holder.cte, write={sq}))
 
-            if (
-                SQLLineageConfig.LATERAL_COLUMN_ALIAS_REFERENCE
-                and bool(self.metadata_provider) is True
-            ):
-                subquery_holder.graph.add_node(sq, **{NodeTag.WRITE: False})
+            subquery_holder.graph.add_node(sq, **{NodeTag.WRITE: False})
 
             holder |= subquery_holder
 

sqllineage/core/parser/sqlfluff/extractors/select.py

@@ -1,6 +1,5 @@
 from sqlfluff.core.parser import BaseSegment
 
-from sqllineage.config import SQLLineageConfig
 from sqllineage.core.holders import SubQueryLineageHolder
 from sqllineage.core.metadata_provider import MetaDataProvider
 from sqllineage.core.parser import SourceHandlerMixin
@@ -57,11 +56,7 @@ def extract(
                         for sq in self.list_subquery(seg):
                             subqueries.append(sq)
 
-        if (
-            SQLLineageConfig.LATERAL_COLUMN_ALIAS_REFERENCE
-            and bool(self.metadata_provider) is True
-        ):
-            self.extract_subquery(subqueries, holder)
+        self.extract_subquery(subqueries, holder)
 
         for segment in segments:
             self._handle_swap_partition(segment, holder)
@@ -89,12 +84,6 @@ def extract(
 
         self.end_of_query_cleanup(holder)
 
-        if not (
-            SQLLineageConfig.LATERAL_COLUMN_ALIAS_REFERENCE
-            and bool(self.metadata_provider)
-        ):
-            self.extract_subquery(subqueries, holder)
-
         holder.expand_wildcard(self.metadata_provider)
 
         return holder

sqllineage/core/parser/sqlfluff/models.py

@@ -4,7 +4,6 @@
 from sqlfluff.core.parser import BaseSegment
 
 from sqllineage import SQLPARSE_DIALECT
-from sqllineage.config import SQLLineageConfig
 from sqllineage.core.models import Column, Schema, SubQuery, Table
 from sqllineage.core.parser.sqlfluff.utils import (
     extract_column_qualifier,
@@ -110,8 +109,7 @@ def of(column: BaseSegment, **kwargs) -> Column:
                     alias,
                     source_columns=source_columns,
                 )
-                if SQLLineageConfig.LATERAL_COLUMN_ALIAS_REFERENCE:
-                    setattr(alias_column, "has_alias", True)
+                setattr(alias_column, "has_alias", True)
                 return alias_column
             if source_columns:
                 column_name = None