From 1d22afdc77d2c4de78b2071d747dfdd0962ce774 Mon Sep 17 00:00:00 2001
From: Thomas Goyne <tg@realm.io>
Date: Wed, 15 May 2019 09:46:22 -0700
Subject: [PATCH] Remove some pointless promises in subscription tests

---
 tests/js/subscription-tests.js | 73 +++++++++++++++-------------------
 1 file changed, 31 insertions(+), 42 deletions(-)

diff --git a/tests/js/subscription-tests.js b/tests/js/subscription-tests.js
index 8b8b3a1c552..b7bc400bfd8 100644
--- a/tests/js/subscription-tests.js
+++ b/tests/js/subscription-tests.js
@@ -34,34 +34,32 @@ function uuid() {
 function getRealm() {
     const AUTH_URL = 'http://127.0.0.1:9080';
     const REALM_URL = 'realm://127.0.0.1:9080/~/' + uuid().replace("-", "_");
-    return new Promise((resolve, reject) => {
-        Realm.Sync.User.login(AUTH_URL, Realm.Sync.Credentials.nickname("admin", true))
-            .then((user) => {
-                const schemas = [
-                    {
-                        name: 'Parent',
-                        properties: {
-                            name: { type: 'string' },
-                            child: 'ObjectA',
-                        }
-                    },
-                    {
-                        name: 'ObjectA',
-                        properties: {
-                            name: { type: 'string' },
-                            parents: { type: 'linkingObjects', objectType: 'Parent', property: 'child' },
-                        }
-                    },
-                ];
-
-                const config = user.createConfiguration({
-                    schema: schemas,
-                    sync: {
-                        url: REALM_URL,
+    return Realm.Sync.User.login(AUTH_URL, Realm.Sync.Credentials.nickname("admin", true))
+        .then((user) => {
+            const schemas = [
+                {
+                    name: 'Parent',
+                    properties: {
+                        name: { type: 'string' },
+                        child: 'ObjectA',
                     }
-                });
-                resolve(new Realm(config));
+                },
+                {
+                    name: 'ObjectA',
+                    properties: {
+                        name: { type: 'string' },
+                        parents: { type: 'linkingObjects', objectType: 'Parent', property: 'child' },
+                    }
+                },
+            ];
+
+            const config = user.createConfiguration({
+                schema: schemas,
+                sync: {
+                    url: REALM_URL,
+                }
             });
+            return new Realm(config);
     });
 }
 
@@ -126,12 +124,9 @@ module.exports = {
 
     testSubscriptionWrapperProperties() {
         return getRealm().then(realm => {
-            return new Promise((resolve, reject) => {
-                const subscription = realm.objects("ObjectA").subscribe("test");
-                TestCase.assertEqual(subscription.name, "test");
-                TestCase.assertEqual(subscription.state, Realm.Sync.SubscriptionState.Creating);
-                resolve();
-            });
+            const subscription = realm.objects("ObjectA").subscribe("test");
+            TestCase.assertEqual(subscription.name, "test");
+            TestCase.assertEqual(subscription.state, Realm.Sync.SubscriptionState.Creating);
         });
     },
 
@@ -328,21 +323,15 @@ module.exports = {
 
     testSubscribeWithoutName() {
         return getRealm().then(realm => {
-            return new Promise((resolve, reject) => {
-                let query = realm.objects("ObjectA");
-                query.subscribe({ update: true, timeToLive: 1000}); // Missing name, doesn't throw
-                resolve();
-            });
+            let query = realm.objects("ObjectA");
+            query.subscribe({ update: true, timeToLive: 1000}); // Missing name, doesn't throw
         });
     },
 
     testSubscribeWithMisspelledConfigParameter() {
         return getRealm().then(realm => {
-            return new Promise((resolve, reject) => {
-                let query = realm.objects("ObjectA");
-                TestCase.assertThrowsContaining(() => query.subscribe({ naem: "myName" }), "Unexpected property in subscription options: 'naem'");
-                resolve();
-            });
+            let query = realm.objects("ObjectA");
+            TestCase.assertThrowsContaining(() => query.subscribe({ naem: "myName" }), "Unexpected property in subscription options: 'naem'");
         });
     },