Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core CAPI is missing the realm_app_config_get_sync_client_config() implementation #7890

Closed
sync-by-unito bot opened this issue Jul 16, 2024 · 2 comments · Fixed by #7891
Closed

Core CAPI is missing the realm_app_config_get_sync_client_config() implementation #7890

sync-by-unito bot opened this issue Jul 16, 2024 · 2 comments · Fixed by #7891
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 16, 2024

In the realm.h file, there is a definition for realm_app_config_get_sync_client_config() to retrieve the realm_sync_client_config_t reference from the realm_app_config_t structure, since it is a member of this struct. Unfortunately, only the function header is provided and there is no implementation for it.
Add the implementation and add or update at least one test that verifies this functionality.

Copy link
Author

sync-by-unito bot commented Jul 16, 2024

➤ PM Bot commented:

Jira ticket: RCORE-2201

Copy link
Author

sync-by-unito bot commented Jul 16, 2024

➤ michael-wb commented:

It seems to be better to restore the original realm_app_config_set_sync_client_config() function, since there are two different types of references to the SyncClientConfig in the C_API:

  • a pointer to the struct stored in the AppConfig
  • a WrapC object when using a SyncClientConfig structure separate from the AppConfig

Only the second one is is compatible with the realm_sync_client_config_t structure used to wrap the SyncClientConfig structure in the C_API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant