[SwiftSyntax] Update to latest 509.0.0 tag #4920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * [SwiftSyntax] Update to latest `release/5.9` commit.
[jpsim](https://github.com/jpsim)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Collaborator
|
What's wrong with SourceKitten by the way? New findings and fixes have appeared in all builds for a few days. |
Collaborator
Author
|
I don't know. There might be some non-determinism in SwiftLint that's surfaced more when linting SourceKitten or maybe some CI machine has a bad checkout? A bad checkout would impact both |
Something similar to this has been merged upstream instead now. This also renames the repo name to SwiftSyntax in preparation for it being in the BCR
jpsim
force-pushed
the
jp-update-swift-syntax-2023-04-22
branch
from
a662842 to
5ce9e5e
Compare
jpsim
changed the title
release/5.9 commit
Collaborator
Author
|
Looks like this update has a small but consistent performance regression of 1-4% slower. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftSyntax Diff: swiftlang/swift-syntax@509.0.0-swift-5.9-DEVELOPMENT-SNAPSHOT-2023-04-10-a...509.0.0-swift-DEVELOPMENT-SNAPSHOT-2023-04-25-b
Also includes changes from #4900 to use the upstream SwiftSyntax BUILD files.