Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Request: Don't add ACL modifiers when they're already the default #5828

Open
Tracked by #319
SimplyDanny opened this issue Oct 18, 2024 · 0 comments
Open
Tracked by #319
Labels
rule-request Requests for a new rules.

Comments

@SimplyDanny
Copy link
Collaborator

SimplyDanny commented Oct 18, 2024

New Rule Request

Avoid redundant access-level modifiers such as internal on top-level declarations.

  1. Why should this rule be added? Share links to existing discussion about what
    the community thinks about this.

    See header.

  2. Provide several examples of what would and wouldn't trigger violations.

    Triggering:

    internal struct S {
      internal let a = 1
    }
    public extension E {
      public func f() {}
    }

    Not triggering:

    public struct S {
      internal let a = 1
    }
  3. Should the rule be configurable, if so what parameters should be configurable?

    Nothing to configure.

  4. Should the rule be opt-in or enabled by default? Why?
    See README.md for guidelines on when to mark a rule as opt-in.

    Opt-in. It will conflict with the explicit_acl rule which is also opt-in.

@SimplyDanny SimplyDanny changed the title Access Modifiers: Don't add modifiers such as internal when they're already the default. Rule Request: Don't add modifiers such as internal when they're already the default Oct 18, 2024
@SimplyDanny SimplyDanny added the rule-request Requests for a new rules. label Oct 18, 2024
@SimplyDanny SimplyDanny changed the title Rule Request: Don't add modifiers such as internal when they're already the default Rule Request: Don't add modifiers when they're already the default Oct 18, 2024
@SimplyDanny SimplyDanny changed the title Rule Request: Don't add modifiers when they're already the default Rule Request: Don't add ACL modifiers when they're already the default Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule-request Requests for a new rules.
Projects
None yet
Development

No branches or pull requests

1 participant