Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_types_order stopped working with partial order set #5755

Open
2 tasks done
username0x0a opened this issue Aug 18, 2024 · 1 comment
Open
2 tasks done

file_types_order stopped working with partial order set #5755

username0x0a opened this issue Aug 18, 2024 · 1 comment
Labels
repro-needed Issues that cannot be reproduced or miss proper descriptive examples.

Comments

@username0x0a
Copy link

username0x0a commented Aug 18, 2024

New Issue Checklist

Bug Description

Previously (with 0.53.0) we had the file_types_order configured like this:

file_types_order:
  order: [[SwiftLintFramework.FileType.mainType], [SwiftLintFramework.FileType.previewProvider]]

so that it only checks that the main SwiftUI type is preceding its related PreviewProvider type.

Now after updating to 0.56.1 I just noticed the values naming in the order parameter changed, so I simply updated the config with this setup:

file_types_order:
  order: [[main_type], [preview_provider]]

which should be equivalent to the previous one in new terms. Yet I'm getting a ton of warnings related to other types (like f.e. extensions between classes, structs or whatever) not defined in our configuration. I find this breaking & I'd love to continue using this rule to just check the order of the specified subset of type identifiers.

Curiously, I can't seem to find any note on a change in the changelog diff in the first place so I can't really say when exactly this change happened.

Environment

  • SwiftLint version: 0.56.1 (updating from 0.53.0)
  • Xcode version: Xcode 15 (unrelated, replicable in CLI)
  • Installation method: Homebrew
@SimplyDanny
Copy link
Collaborator

Browsing through the Git history I cannot believe a value like SwiftLintFramework.FileType.mainType has ever worked. 😅

Also, that you now suddenly see more warnings doesn't really make sense.

Can you provide a very succinct example with a configuration that doesn't trigger 0.53.0 but 0.56.1? Can you even try how 0.54.0 and 0.55.0 behave?

@SimplyDanny SimplyDanny added the repro-needed Issues that cannot be reproduced or miss proper descriptive examples. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repro-needed Issues that cannot be reproduced or miss proper descriptive examples.
Projects
None yet
Development

No branches or pull requests

2 participants