Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintuitive behavior for parent and child configurations w.r.t. implicit overwrites #5724

Open
SimplyDanny opened this issue Aug 3, 2024 · 1 comment
Labels
discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. enhancement Ideas for improvements of existing features and rules.

Comments

@SimplyDanny
Copy link
Collaborator

All options possible in a configuration have a default value which is implicitly set even if an option is not mentioned in a certain configuration. Together with the rule that child configurations specialize parent configurations, all options set in the parent are overridden by the values in the child even if they are not explicitly set therein.

One example is strict which is false by default. Setting strict: true in the parent, but not mentioning it at all in the child resets it to its default value false. This is most likely not the intention of the user.

We should change the behavior to something more intuitive. This would definitely be a breaking change which needs to be properly communicated. The new logic must be well thought out and needs to consider parent_config and child_config.

@SimplyDanny SimplyDanny added enhancement Ideas for improvements of existing features and rules. discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. labels Aug 3, 2024
@mildm8nnered
Copy link
Collaborator

Without having thought about it too much, I guess something like parent takes precedence over the default - i.e. the child wins, but only for things it sets explicitly.

Somewhat tangentially, it would be really nice to have some way to easily define command line options and config file equivalents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Development

No branches or pull requests

2 participants