opening_brace violation issue

[tungfam]

Running v 0.22.0 and checked the created issues.

Bug Report

Here is my code:

The warning says:

Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

Adding disable rule:

And got this issue:

Superfluous Disable Command Violation: SwiftLint rule 'opening_brace' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Issue: There is a conflict of warning and error.

PS: though, disabling using //swiftlint:disable opening_brace works. but if use :this - having issues.

[marcelofabri]

The issue is that opening_brace rule currently does not do a very good job on reporting the location.

I'd suggest you to use one of the alternatives:

func foo()
{ // swiftlint:disable:previous opening_brace

}

// swiftlint:disable:next opening_brace
func foo()
{

}

Alternatively, you can disable superfluous_disable_command as you'd with any rule: in your configuration or with comments.

I think we should keep this open to track improving opening_brace violation locations.

[tungfam]

Yeah, I made a workaround. Thanks!