Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customize severity / color of individual rules #130

Closed
buildreactive opened this issue Sep 11, 2015 · 2 comments
Closed

Ability to customize severity / color of individual rules #130

buildreactive opened this issue Sep 11, 2015 · 2 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@buildreactive
Copy link

I know there are several other tickets regarding customization of rules (e.g., #26) but I don't think this is covered:

It would be ideal to be able to customize not only rule parameters (e.g., the length of a line before the line-length-warning is triggered), but also color. Right now we have two colors: Yellow for warnings and red for errors. Severity tends to be in two states ("it's yellow ignore it" and "it's red I have to fix it").

Ideally, I could introduce a pale green (for, say, "FIXME" and "TODO" rules). This makes a clear distinction between to-do items that probably can be ignored, versus warnings that really should not be ignored.

@jpsim
Copy link
Collaborator

jpsim commented Sep 11, 2015

The colors rendered in Xcode are actually done by Xcode itself. They're built-in diagnostic UI elements. There's also a third one: warning (yellow), error (red) and note (gray). We don't have any rules that render notes at the moment, but I could be convinced to update the FIXME/TODO rules to be notes, but I think it's more appropriate to keep them as warnings.

@jpsim jpsim added the enhancement Ideas for improvements of existing features and rules. label Sep 11, 2015
@buildreactive
Copy link
Author

This would be a perfect configuration item. I personally would make them notes – but I can see how some would prefer to keep them as warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Development

No branches or pull requests

2 participants