redundant_optional_initialization rule bug

[Agarunov]

class Foo: NSObject {
    let descr: String?
    let name: String?

    lazy private(set) var bazz: String = {
        if self.name != nil && self.name!.isEmpty == false {
            return self.name!
        } else {
            return ""
        }

    }()

   ...
}

this code (self.name != nil) cause redundant_optional_initialization violation

SwiftLint 0.16.0

[marcelofabri]

Are you using Swift 2.3?

[Agarunov]

@marcelofabri Swift 3.0

[marcelofabri]

I couldn't reproduce it with Swift 3.0 and 0.16 😬

Are you sure this isolated example triggers?

[Agarunov]

@marcelofabri sorry for wrong example

Here is new code which repoduce bug

class Address: NSObject {
    
    let country: String?
    let city: String?
        
    lazy private(set) var fullAddress: String? = {
        var names = [String]()

        if self.country != nil && self.country!.isEmpty == false {
            names.append(self.country!)
        }
        
        if self.city != nil && self.city!.isEmpty == false {
            names.append(self.city!)
        }

        return names.joined(separator: ", ")
    }()
        
    init(country: String?, city: String?) {
        self.country = country
        self.city = city
    }
    
}

code self.name != nil cause redundant_optional_initialization violation

[marcelofabri]

OK, I was able to reproduce it now. Thanks!