Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different kitchen datasets for different methods #117

Open
ziyadsheeba opened this issue Nov 4, 2024 · 0 comments
Open

Different kitchen datasets for different methods #117

ziyadsheeba opened this issue Nov 4, 2024 · 0 comments

Comments

@ziyadsheeba
Copy link

ziyadsheeba commented Nov 4, 2024

I was lookin through the Franka Kitchen experiments, and realized that in your training logs here, you use the dataset diffusion_policy.dataset.kitchen_lowdim_dataset.KitchenLowdimDataset for all the other methods but for diffusion policy you are using class diffusion_policy.dataset.kitchen_lowdim_dataset.KitchenMjlLowdimDataset. I checked the parsed mjl files and there are 605 trajectories compared to the 566 trajectories in the KitchenLowdimDataset. Why are you not using the same dataset for all the different methods? It seems like having 40 more trajectories does not result in a fair comparison.

Thanks!

@ziyadsheeba ziyadsheeba reopened this Nov 4, 2024
@ziyadsheeba ziyadsheeba changed the title Kitchen Data Mismatch Different kitchen datasets for different methods Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant