Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #289: Inconsistent table typography sizing #1215

Merged
merged 9 commits into from
Aug 26, 2022
Merged

Fixes #289: Inconsistent table typography sizing #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
710ab28
Fix table typography inconsistent sizing
nienn Aug 23, 2021
f8eb0db
Remove rule duplication
nienn Aug 23, 2021
9558a2f
Remove <ol> and fix build
nienn Aug 23, 2021
b239f1e
Merge branch 'master' into nienn/fix-table-typography-sizing
nienn Aug 23, 2021
ec43cfd
Merge branch 'master' of github.com:readthedocs/sphinx_rtd_theme into…
benjaoming Aug 24, 2022
c87fe21
Build new theme.css for https://github.com/readthedocs/sphinx_rtd_the…
benjaoming Aug 24, 2022
4ed8c4a
Add an example rendering with paragraphs inside tables
benjaoming Aug 24, 2022
0ec645c
Merge remote-tracking branch 'upstream/master' into HEAD
benjaoming Aug 26, 2022
b9aef94
build theme.css for https://github.com/readthedocs/sphinx_rtd_theme/p…
benjaoming Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions docs/demo/lists_tables.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,3 +346,26 @@ List Tables

This is a long caption for a figure. Lorem ipsum dolor sit amet, consectetur adipiscing elit.
Donec porttitor dolor in odio posuere, vitae ornare libero mattis. In lobortis justo vestibulum nibh aliquet, non.


Tables with paragraphs
----------------------

.. regression test for https://github.com/readthedocs/sphinx_rtd_theme/issues/289

Test to see that tables behave well with nested paragraphs.

+------------+----------+-------------------------+
| Precedence | Operator | Description |
+============+==========+=========================+
| 1 | \:: | Scope resolution |
+------------+----------+-------------------------+
| 2 | ( ) | Function call |
| | | |
| | [ ] | Subscript |
| | | |
| | . | Member access |
| | | |
| | .{ } | Bit-field concatenation |
+------------+----------+-------------------------+

2 changes: 1 addition & 1 deletion sphinx_rtd_theme/static/css/theme.css
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 6 additions & 1 deletion src/sass/_theme_rst.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,12 @@
&:hover .headerlink
opacity: 1

// Consistent font sizing for table typography
.wy-table
th, td
p, ul
font-size: inherit

// override the Wyrm accessibility anti-pattern of hiding button focus
.btn:focus
outline: 2px solid
Expand Down Expand Up @@ -378,7 +384,6 @@
td
border: none
p
font-size: inherit
line-height: inherit
td > strong
display: inline-block
Expand Down