Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer styles for <kbd> #669

Closed
honzajavorek opened this issue Sep 17, 2018 · 3 comments
Closed

Nicer styles for <kbd> #669

honzajavorek opened this issue Sep 17, 2018 · 3 comments
Assignees
@Blendify
Labels
Improvement Minor improvement to code

Comments

@honzajavorek
Copy link

Problem

Currently the :kbd: role, or more precisely the <kbd> HTML tag, renders like this:

image

I think it would be nicer if the styles were closer to what GitHub does, so one could document keys to press or buttons to click with more visual aid:

Download

Reproducible Project

Link: https://cojeapi.readthedocs.io/cs/latest/content/02-klient-server.html#klient-v-terminalu-curl (the "Windows" tab)

Click on :kbd:`Download`.

Expected Results

The role renders like something resembling a button or a computer key.

Environment Info

  • Python Version: not relevant
  • Sphinx Version: not relevant
  • RTD Theme Version: 0.4.0
@honzajavorek honzajavorek mentioned this issue Sep 17, 2018
Closed
@Blendify Blendify self-assigned this Sep 17, 2018
@Blendify Blendify added the Improvement Minor improvement to code label Sep 17, 2018
@Blendify
Copy link
Member

I meant to write a patch for this a while ago. Will write one soon!

@honzajavorek
Copy link
Author

Great! If you need any help, let me know. I'm not great with contemporary CSS, but I guess this would be in my powers 😄

Blendify added a commit that referenced this issue Oct 1, 2018
@Blendify
Nicer styles for <kbd>
dd6bef9 
Fixes #669 

Style:
![literal](https://cloud.githubusercontent.com/assets/15183467/24159963/f22cf0c2-0e36-11e7-8e58-d2842145c37e.PNG)
@Blendify Blendify mentioned this issue Oct 1, 2018
Merged
@stsewd
Copy link
Member

stsewd commented Feb 21, 2019

Fixed in #677

@stsewd stsewd closed this as completed Feb 21, 2019
@fishermans-friend fishermans-friend mentioned this issue Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Blendify Blendify

Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@honzajavorek @stsewd @Blendify