Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make usage of sphinxcontrib-jquery #241

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 24, 2022

Sphinx 6.x is removing jQuery. So, we need to manually add it.

Closes #160
Based on readthedocs/readthedocs.org#9665


📚 Documentation preview 📚: https://sphinx-hoverxref--241.org.readthedocs.build/en/241/


📚 Documentation preview 📚: https://read-the-docs-sphinx-hoverxref--241.com.readthedocs.build/en/241/

Sphinx 6.x is removing jQuery. So, we need to manually add it.
@humitos humitos requested review from a team as code owners October 24, 2022 18:02
@humitos humitos self-assigned this Oct 24, 2022
@humitos
Copy link
Member Author

humitos commented Oct 24, 2022

I tested this on my local environment manually and it works fine. cc @benjaoming @AA-Turner. Thanks! 💯

@benjaoming
Copy link
Contributor

@humitos could we also bump docs/requirements.txt to use the latest Sphinx pre-release?

@humitos
Copy link
Member Author

humitos commented Oct 25, 2022

@benjaoming yes, I will create another PR for that 👍🏼

@humitos humitos merged commit 52afd61 into main Oct 25, 2022
@humitos humitos deleted the humitos/depend-on-sphinxcontrib-jquery branch October 25, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Include jQuery as dependency
3 participants